You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/04/20 14:44:48 UTC
[GitHub] [accumulo] keith-turner opened a new pull request, #3324: Rename TabletLocator to TabletCache
keith-turner opened a new pull request, #3324:
URL: https://github.com/apache/accumulo/pull/3324
In #3292 the TabletLocator was modified to cache tablets with out a location. This rename is in response to the more general purpose of the client side tablet cache.
All changes in the PR were done using IDE refactoring, except for the addition of one comment. So the code does not really need review, only the new names.
TabletLocator was rename to TableCache
TabletLocator.locateTablet was rename to findTablet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner merged pull request #3324: Rename TabletLocator to TabletCache
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner merged PR #3324:
URL: https://github.com/apache/accumulo/pull/3324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #3324: Rename TabletLocator to TabletCache
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #3324:
URL: https://github.com/apache/accumulo/pull/3324#issuecomment-1516642469
@dlmarion I made some renames that were internal to the class after your approval in 9941b4d. Let me know of there is anything of concern with that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3324: Rename TabletLocator to TabletCache
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on PR #3324:
URL: https://github.com/apache/accumulo/pull/3324#issuecomment-1516518272
I have no issue with merging with `TabletCache`, but I wonder if `TabletLocationCache` is a better name. Not that `TabletCache` is a bad name, but there are other classes (e.g. `MetadataLocationObtainer`) and variables (e.g. `locator`) that imply location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #3324: Rename TabletLocator to TabletCache
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on PR #3324:
URL: https://github.com/apache/accumulo/pull/3324#issuecomment-1516613217
> I have no issue with merging with TabletCache, but I wonder if TabletLocationCache is a better name. Not that TabletCache is a bad name, but there are other classes (e.g. MetadataLocationObtainer) and variables (e.g. locator) that imply location.
I don't like location in the name since the location is optional. Was thinking the name needed more specificity though after reading the comment, changed the name to ClientTabletCache to make it more specific. I realized I had another todo in the code for doing a rename, so I did that. I also renamed MetadataLocationObtainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org