You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/10/15 17:42:14 UTC

[GitHub] [camel] gilvansfilho commented on a diff in pull request #8549: Cleanup jpa component

gilvansfilho commented on code in PR #8549:
URL: https://github.com/apache/camel/pull/8549#discussion_r996334893


##########
components/camel-jpa/src/main/java/org/apache/camel/component/jpa/JpaEndpoint.java:
##########
@@ -185,6 +185,16 @@ protected String createEndpointUri() {
         return "jpa" + (entityType != null ? "://" + entityType.getName() : "");
     }
 
+    @Override

Review Comment:
   Sonar cares about additional [subclass fields and the needeed of add them in equals and hash code methods](https://rules.sonarsource.com/java/RSPEC-2160). In that case this is not necessary as equality is based on context name and endpoint Uri so additional fields dont need to be considered. However sonar points as issue.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org