You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/14 08:56:14 UTC

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1243: feat: update secret referenced by ingress

tao12345666333 commented on code in PR #1243:
URL: https://github.com/apache/apisix-ingress-controller/pull/1243#discussion_r970520059


##########
test/e2e/suite-ingress/suite-ingress-resource/ssl.go:
##########
@@ -158,9 +158,7 @@ RU+QPRECgYB6XW24EI5+w3STbpnc6VoTS+sy9I9abTJPYo9LpCJwfMYc9Tg9Cx2K
 			assert.Nil(ginkgo.GinkgoT(), err, "list tls error")
 			assert.Len(ginkgo.GinkgoT(), tls, 1, "tls number not expect")
 			assert.Equal(ginkgo.GinkgoT(), tls[0].Snis[0], host, "tls host is error")
-			assert.Equal(ginkgo.GinkgoT(), tls[0].Labels, map[string]string{
-				"managed-by": "apisix-ingress-controller",
-			})
+			assert.Equal(ginkgo.GinkgoT(), tls[0].Labels["managed-by"], "apisix-ingress-controller")

Review Comment:
   I think it is possible to check both meta_secret_namespace and meta_secret_name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org