You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/05/21 23:26:16 UTC

Review Request 67240: HIVE-19642 add cache dump when LLAP cache is full on branch-2 (and fix retry issues)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67240/
-----------------------------------------------------------

Review request for hive and Prasanth_J.


Repository: hive-git


Description
-------

see jira


Diffs
-----

  llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java 2132574fb54f6993c06c22b3ec57e198f3278caa 
  llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 58535d7646eb5e5e4ed91f1431ca6d12e8480dea 


Diff: https://reviews.apache.org/r/67240/diff/1/


Testing
-------


Thanks,

Sergey Shelukhin


Re: Review Request 67240: HIVE-19642 add cache dump when LLAP cache is full on branch-2 (and fix retry issues)

Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67240/#review203541
-----------------------------------------------------------




llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java
Lines 41 (patched)
<https://reviews.apache.org/r/67240/#comment285833>

    nit: remove useless todo



llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java
Lines 154 (patched)
<https://reviews.apache.org/r/67240/#comment285834>

    follow up ticket?


- Prasanth_J


On May 21, 2018, 11:26 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67240/
> -----------------------------------------------------------
> 
> (Updated May 21, 2018, 11:26 p.m.)
> 
> 
> Review request for hive and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java 2132574fb54f6993c06c22b3ec57e198f3278caa 
>   llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 58535d7646eb5e5e4ed91f1431ca6d12e8480dea 
> 
> 
> Diff: https://reviews.apache.org/r/67240/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>