You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Hugues Malphettes (JIRA)" <ji...@apache.org> on 2009/10/08 03:34:32 UTC

[jira] Created: (BUILDR-326) support unzipping tar.gz files

support unzipping tar.gz files
------------------------------

                 Key: BUILDR-326
                 URL: https://issues.apache.org/jira/browse/BUILDR-326
             Project: Buildr
          Issue Type: Improvement
          Components: Packaging
    Affects Versions: 1.3.4
            Reporter: Hugues Malphettes


It would be nice to handle this type of code where the artifact points to a tgz file
build unzip(_("target/equinox-runtime")=>artifact(EQUINOX_RUNTIME_FRAMEWORK))




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-326) support unzipping tar.gz files

Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886818#action_12886818 ] 

Antoine Toulme commented on BUILDR-326:
---------------------------------------

Thanks Sam!

11:36:49~/w/buildr>svn ci CHANGELOG lib/buildr/packaging/ziptask.rb -m "Follow up on BUILDR-326, binary safe for Windows"
Sending        CHANGELOG
Sending        lib/buildr/packaging/ziptask.rb
Transmitting file data ..
Committed revision 962631.

> support unzipping tar.gz files
> ------------------------------
>
>                 Key: BUILDR-326
>                 URL: https://issues.apache.org/jira/browse/BUILDR-326
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Hugues Malphettes
>             Fix For: 1.4
>
>         Attachments: BUILDR-326.txt, ziptask_support_for_tgz.diff
>
>
> It would be nice to handle this type of code where the artifact points to a tgz file
> build unzip(_("target/equinox-runtime")=>artifact(EQUINOX_RUNTIME_FRAMEWORK))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (BUILDR-326) support unzipping tar.gz files

Posted by "Alex Boisvert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Boisvert resolved BUILDR-326.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4

Patch applied.   Nice work, thanks!!

Sending        CHANGELOG
Sending        lib/buildr/packaging/tar.rb
Sending        lib/buildr/packaging/ziptask.rb
Sending        spec/packaging/archive_spec.rb
Transmitting file data ....
Committed revision 917064.


> support unzipping tar.gz files
> ------------------------------
>
>                 Key: BUILDR-326
>                 URL: https://issues.apache.org/jira/browse/BUILDR-326
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Hugues Malphettes
>             Fix For: 1.4
>
>         Attachments: BUILDR-326.txt, ziptask_support_for_tgz.diff
>
>
> It would be nice to handle this type of code where the artifact points to a tgz file
> build unzip(_("target/equinox-runtime")=>artifact(EQUINOX_RUNTIME_FRAMEWORK))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-326) support unzipping tar.gz files

Posted by "Hugues Malphettes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839354#action_12839354 ] 

Hugues Malphettes commented on BUILDR-326:
------------------------------------------

Cheers, Antoine and Alex!

> support unzipping tar.gz files
> ------------------------------
>
>                 Key: BUILDR-326
>                 URL: https://issues.apache.org/jira/browse/BUILDR-326
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Hugues Malphettes
>             Fix For: 1.4
>
>         Attachments: BUILDR-326.txt, ziptask_support_for_tgz.diff
>
>
> It would be nice to handle this type of code where the artifact points to a tgz file
> build unzip(_("target/equinox-runtime")=>artifact(EQUINOX_RUNTIME_FRAMEWORK))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-326) support unzipping tar.gz files

Posted by "Hugues Malphettes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hugues Malphettes updated BUILDR-326:
-------------------------------------

    Attachment: ziptask_support_for_tgz.diff

As a starting point this patch will add such support by adding some code to the Unzip task.
It works for me to extract a complete tgz file.
The include/exclude don't work at this point.

Please let me know if this helps or if you would rather see this somewhere else in buildr.

> support unzipping tar.gz files
> ------------------------------
>
>                 Key: BUILDR-326
>                 URL: https://issues.apache.org/jira/browse/BUILDR-326
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Hugues Malphettes
>         Attachments: ziptask_support_for_tgz.diff
>
>
> It would be nice to handle this type of code where the artifact points to a tgz file
> build unzip(_("target/equinox-runtime")=>artifact(EQUINOX_RUNTIME_FRAMEWORK))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-326) support unzipping tar.gz files

Posted by "Sam Hendley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12886791#action_12886791 ] 

Sam Hendley commented on BUILDR-326:
------------------------------------

There is a bug in this that causes it to corrupt files in windows. On line 163:

File.open(dest, 'w') {|f| f.write entry.read}

That needs to be a binary safe write: File.open(dest, 'wb').

Commit on github: http://github.com/samhendley/buildr/commit/a9d2805b70b2b67ea44b3d75a0cee9cdffbba190

> support unzipping tar.gz files
> ------------------------------
>
>                 Key: BUILDR-326
>                 URL: https://issues.apache.org/jira/browse/BUILDR-326
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Hugues Malphettes
>             Fix For: 1.4
>
>         Attachments: BUILDR-326.txt, ziptask_support_for_tgz.diff
>
>
> It would be nice to handle this type of code where the artifact points to a tgz file
> build unzip(_("target/equinox-runtime")=>artifact(EQUINOX_RUNTIME_FRAMEWORK))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (BUILDR-326) support unzipping tar.gz files

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BUILDR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887068#action_12887068 ] 

Hudson commented on BUILDR-326:
-------------------------------

Integrated in Buildr-ci-build #59 (See [http://hudson.zones.apache.org/hudson/job/Buildr-ci-build/59/])
    Follow up on BUILDR-326, binary safe for Windows


> support unzipping tar.gz files
> ------------------------------
>
>                 Key: BUILDR-326
>                 URL: https://issues.apache.org/jira/browse/BUILDR-326
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Hugues Malphettes
>             Fix For: 1.4
>
>         Attachments: BUILDR-326.txt, ziptask_support_for_tgz.diff
>
>
> It would be nice to handle this type of code where the artifact points to a tgz file
> build unzip(_("target/equinox-runtime")=>artifact(EQUINOX_RUNTIME_FRAMEWORK))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (BUILDR-326) support unzipping tar.gz files

Posted by "Antoine Toulme (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BUILDR-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antoine Toulme updated BUILDR-326:
----------------------------------

    Attachment: BUILDR-326.txt

Here is a new patch that comes with specs, and also includes the include/exclude support.

> support unzipping tar.gz files
> ------------------------------
>
>                 Key: BUILDR-326
>                 URL: https://issues.apache.org/jira/browse/BUILDR-326
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Packaging
>    Affects Versions: 1.3.4
>            Reporter: Hugues Malphettes
>         Attachments: BUILDR-326.txt, ziptask_support_for_tgz.diff
>
>
> It would be nice to handle this type of code where the artifact points to a tgz file
> build unzip(_("target/equinox-runtime")=>artifact(EQUINOX_RUNTIME_FRAMEWORK))

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.