[GitHub] [spark] maropu commented on a change in pull request #27481: [SPARK-30758][SQL][TESTS] Improve bracketed comments tests.

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #27481: [SPARK-30758][SQL][TESTS] Improve bracketed comments tests.
URL: https://github.com/apache/spark/pull/27481#discussion_r376746662
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/postgreSQL/comments.sql
 ##########
 @@ -26,23 +26,23 @@ SELECT 'after multi-line' AS fifth;
 SELECT 'trailing' as x1; -- inside block comment
 */
 
-/* This block comment surrounds a query which itself has a block comment...
-SELECT /* embedded single line */ 'embedded' AS x2;
-*/
+-- /* This block comment surrounds a query which itself has a block comment...
+-- SELECT /* embedded single line */ 'embedded' AS x2;
+-- */
 
 
 Review comment:
   We need this change to comment out these tests in branch-3.0? If branch-3.0 doesn't support these nested comments,  its better to fix them so that the test could throw an exception for nested comments here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org