[GitHub] [camel-k] squakez commented on a diff in pull request #3556: feat(cli): Force arguments for the rebuild command

[GitBox <gi...@apache.org>]

squakez commented on code in PR #3556:
URL: https://github.com/apache/camel-k/pull/3556#discussion_r951100176


##########
pkg/cmd/rebuild.go:
##########
@@ -84,9 +108,10 @@ func (o *rebuildCmdOptions) listAllIntegrations(c client.Client) ([]v1.Integrati
 func (o *rebuildCmdOptions) getIntegrations(c client.Client, names []string) ([]v1.Integration, error) {
 	ints := make([]v1.Integration, 0, len(names))
 	for _, n := range names {
-		it := v1.NewIntegration(o.Namespace, n)
+		name := kubernetes.SanitizeName(n)

Review Comment:
   Why do we need to sanitize the name? Isn't this value already the one passed by the user?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org