[GitHub] [hive] miklosgergely commented on a change in pull request #1889: HIVE-24661: Do Not Stringify Exception in Logger messages

[GitBox <gi...@apache.org>]

miklosgergely commented on a change in pull request #1889:
URL: https://github.com/apache/hive/pull/1889#discussion_r560585140



##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java
##########
@@ -1028,11 +1028,11 @@ public boolean checkFailedCompactions(CompactionInfo ci) throws MetaException {
         return (numFailed == failedThreshold) && !needsRetry;
       }
       catch (SQLException e) {
-        LOG.error("Unable to check for failed compactions " + e.getMessage());
+        LOG.error("Unable to check for failed compactions" + e.getMessage());

Review comment:
       I don't see any reason not to log out the full stack trace even if we have to retry it later, but if we decide to log only the error message, then we need that space, or even better a ": ".




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org