You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2021/03/29 08:01:56 UTC
[GitHub] [zookeeper] arshadmohammad opened a new pull request #1663: ZOOKEEPER-4267: Fix check-style issues
arshadmohammad opened a new pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663
Formatted ZKHostnameVerifierTest to fix check-style issue :(whitespace) OperatorWrap: '+' should be on a new line
Formatted one line in QuorumPeerMainTest to fix check-style issue: (whitespace) ParenPad: '(' is followed by whitespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-810151135
merged to branch-3.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad edited a comment on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
arshadmohammad edited a comment on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-810098037
CertificatesToPlayWith check-style issues are suppressed, somehow my environment suppress is not effective. Master branch has checkstyle issues only in this class. So master ci is not failing because the suppression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-810098037
CertificatesToPlayWith check-style issues are suppressed, somehow my environment suppress is not effective. Master branch has checkstyle issues only in this branch. So master ci is not failing because this suppression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-809956567
why CI passed on all of the other patches ?
we are running checkstyle against every GitHub PR validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad edited a comment on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
arshadmohammad edited a comment on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-810115590
@eolivelli,
I have made changes after your approval, please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-810105884
CertificatesToPlayWith changes are fixable, better to fix it. I will remove the suppression from checkstyleSuppressions.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-810028475
> why CI passed on all of the other patches ?
> we are running checkstyle against every GitHub PR validation
May be CI is using different check-style rule set. I will try to find it out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-810100667
QuorumPeerMainTest has check-style issue only in branch-3.6. CI is not failing as for branch-3.6 CI is running on master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] arshadmohammad commented on pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
arshadmohammad commented on pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663#issuecomment-810115590
@eolivelli, have made changes after your approval, please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli closed pull request #1663: ZOOKEEPER-4267: Fix check-style issues
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1663:
URL: https://github.com/apache/zookeeper/pull/1663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org