You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/08/31 00:31:54 UTC

[GitHub] wujimin commented on a change in pull request #885: [SCB-859] Generate traceid

wujimin commented on a change in pull request #885:  [SCB-859] Generate traceid
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/885#discussion_r214218334
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/Invocation.java
 ##########
 @@ -188,11 +209,46 @@ public String getMicroserviceQualifiedName() {
     return operationMeta.getMicroserviceQualifiedName();
   }
 
+  protected void initTraceId() {
+    for (TraceIdGenerator traceIdGenerator : TRACE_ID_GENERATORS) {
+      initTraceId(traceIdGenerator);
 
 Review comment:
   ok
   customers should have a chance to override generator for the same traceId key
   i will enhance the init logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services