You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Dmitriy Pavlov <dp...@apache.org> on 2023/10/24 16:11:41 UTC

Re: [PROPOSAL] Move Ignite 2.x to JDK11 compilation

++1 for testing using JDK11

+0 for switching off support of JDK8 runtimes and class version (unless
compilation using JDK11 is done with -target=1.8 our users won't be able to
run Ignite using Java 8).

I suggest the following next steps: once tests are completely fine on
Teamcity using JDK 11, we start a separate thread named like:
"[VOTE] discontinuing JDK 8 since the 2.16 release"
to make the issue for end users more obvious. Since Nikita volunteers to be
a Release Manager, I suppose that 2.16 will be released quite soon.

I personally prefer to switch to newer Java. Using newer runtime helps us
to provide speed and scale, since JVM is developed all the time. But I
might be unaware of the risks, so let's discuss it later with the entire
dev community.

Sincerely,
Dmitriy Pavlov

ср, 30 авг. 2023 г. в 19:09, Ivan Daschinsky <iv...@gmail.com>:

> +1, sounds reasonable for the open source project. IMHO, Eclipse Temurin
> JDK is a rule of thumb choice nowadays.
>
> ср, 30 авг. 2023 г. в 18:40, Peter Ivanov <mr...@gmail.com>:
>
> > Hi, Igniters!
> >
> > As part of this proposal I would also like to discuss the JDK vendors we
> > are using on our CI platforms TeamCIty.
> > Historically, Ignite 2.x is being built under Oracle's edition - mostly
> > because of some features like JFR or similar.
> > However today we have pretty much solid alternative represented by
> OpenJDK
> > and its most popular build Eclipse Temurin, which provides every required
> > version for our needs (and especially LTS versions 1.8, 11 and 17) with
> all
> > necessary updates.
> >
> > So, I suggest we update our build agents for TeamCity accordingly,
> provide
> > OpenJDK framework for those 3 major versions and discontinue Oracle's
> > builds.
> > WDYT?
> >
> > пт, 25 авг. 2023 г. в 12:13, Ivan Daschinsky <iv...@gmail.com>:
> >
> > > +1. It's time to do it at last.
> > >
> > > пт, 25 авг. 2023 г. в 12:06, Peter Ivanov <mr...@gmail.com>:
> > >
> > > > Mostly, yes.
> > > >
> > > > In other words - proposal is about starting shipping Apache Ignite
> > > releases
> > > > with JDK11 compiled binaries thus dropping JDK8-10 runtime support.
> > > >
> > > > пт, 25 авг. 2023 г. в 12:03, Anton Vinogradov <av...@apache.org>:
> > > >
> > > > > I looks like you're proposing not migration to 2.11 (because it is
> > > > already
> > > > > supported), but Java 8-9 support dropping.
> > > > >
> > > > > On Fri, Aug 25, 2023 at 11:54 AM Peter Ivanov <vv...@apache.org>
> > > > wrote:
> > > > >
> > > > > > Hi, Igniters!
> > > > > >
> > > > > >
> > > > > > I would like to propose the next, if you don't mind me saying,
> > > > > > revolutionary step forward in our project: moving Ignite 2.x
> > > > compilation
> > > > > to
> > > > > > JDK11 minimum version.
> > > > > > I'd rather not make arguments, pros and cons other that currently
> > > exist
> > > > > in
> > > > > > Java world - you know them better than me. Let's just say that it
> > > seems
> > > > > > that time has come - consider at least that JDK11 as the LTS
> > version
> > > is
> > > > > > already about 4 and a half years on the go, and Ignite 3.x
> started
> > > from
> > > > > > JDK11 right away.
> > > > > >
> > > > > > This change may possibly require from us additional efforts on
> > > > supporting
> > > > > > the last version with JDK8 in terms of releasing additional
> patches
> > > and
> > > > > > hotfixes a bit longer than usual. However, this is up to the
> > > community
> > > > to
> > > > > > decide.
> > > > > >
> > > > > > Currently, Apache Ignite 2.x (with Extensions as well) is already
> > > > > prepared
> > > > > > for being compiled with JDK11 and almost all tests are passing.
> If
> > we
> > > > > come
> > > > > > to an agreement about this proposal and designate the next
> version
> > > that
> > > > > > will become the first to provide JDK11 compiled binaries - I am
> > ready
> > > > to
> > > > > > start the process of updating the TeamCity building project
> > > > accordingly.
> > > > > >
> > > > > >
> > > > > > Please, share your thoughts.
> > > > > >
> > > > >
> > > >
> > >
> > >
> > > --
> > > Sincerely yours, Ivan Daschinskiy
> > >
> >
>
>
> --
> Sincerely yours, Ivan Daschinskiy
>

Re: [PROPOSAL] Move Ignite 2.x to JDK11 compilation

Posted by Peter Ivanov <mr...@gmail.com>.
Hi, Maksim.

As far as I know - TeamCity is fully prepared for transfer.
It will take a couple of hours (with tests) to move to JDK11 as default and
remove possible JDK8 leftovers.

пт, 12 июл. 2024 г. в 13:26, Maksim Timonin <ti...@apache.org>:

> Hi, Igniters!
>
> I suggest it's time to return to the discussion. There were 2 issues that
> blocked the sources moving from jdk1.8 to jdk11 [1, 2] and they have now
> been resolved. I have prepared a patch that changes maven.source.version to
> 11 and it passes MTCGA without blockers [3]. TeamCity already runs RunAll
> every night under jdk11 [4], so changing the default java version should
> not break anything.
>
> I believe it's time we can make the move. The plan is as follows:
>
> 1. Conduct a vote "Move Ignite 2 sources to JDK11".
> 2. Upgrade all TeamCity jobs from jdk1.8 to jdk11.
> 3. Review and merge the patch [3] that changes `maven.source.version` in
> Ignite's pom.xml to 11. This means that Apache Ignite 2.17 will be built
> using jdk11.
> 4. Clean up all code that relies on jdk1.8.
>
> Let's discuss this again. Peter, is there anything that needs to be done on
> TeamCity before the upgrade?
>
> [1] https://issues.apache.org/jira/browse/IGNITE-13202
> [2] https://issues.apache.org/jira/browse/IGNITE-22671
> [3] https://issues.apache.org/jira/browse/IGNITE-22669
> [4]
>
> https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_RunAll?mode=builds&tag=JDK_11
>
> On Wed, Oct 25, 2023 at 4:15 AM Николай Ижиков <ni...@apache.org>
> wrote:
>
> > +1
> >
> > > 24 окт. 2023 г., в 19:25, Anton Vinogradov <av...@apache.org> написал(а):
> > >
> > > ++1 for switch to the OpenJDK framework
> > >
> > > As to original question, I propose to (step-by-step):
> > > 1) Switch to java 11 testing instead of 8
> > > 2) Fix java 11 release
> > > 3) Switch to maven.compiler.source 11 (Vote required)
> > >
> > > On Tue, Oct 24, 2023 at 7:12 PM Dmitriy Pavlov <dp...@apache.org>
> > wrote:
> > >
> > >> ++1 for testing using JDK11
> > >>
> > >> +0 for switching off support of JDK8 runtimes and class version
> (unless
> > >> compilation using JDK11 is done with -target=1.8 our users won't be
> > able to
> > >> run Ignite using Java 8).
> > >>
> > >> I suggest the following next steps: once tests are completely fine on
> > >> Teamcity using JDK 11, we start a separate thread named like:
> > >> "[VOTE] discontinuing JDK 8 since the 2.16 release"
> > >> to make the issue for end users more obvious. Since Nikita volunteers
> > to be
> > >> a Release Manager, I suppose that 2.16 will be released quite soon.
> > >>
> > >> I personally prefer to switch to newer Java. Using newer runtime helps
> > us
> > >> to provide speed and scale, since JVM is developed all the time. But I
> > >> might be unaware of the risks, so let's discuss it later with the
> entire
> > >> dev community.
> > >>
> > >> Sincerely,
> > >> Dmitriy Pavlov
> > >>
> > >> ср, 30 авг. 2023 г. в 19:09, Ivan Daschinsky <iv...@gmail.com>:
> > >>
> > >>> +1, sounds reasonable for the open source project. IMHO, Eclipse
> > Temurin
> > >>> JDK is a rule of thumb choice nowadays.
> > >>>
> > >>> ср, 30 авг. 2023 г. в 18:40, Peter Ivanov <mr...@gmail.com>:
> > >>>
> > >>>> Hi, Igniters!
> > >>>>
> > >>>> As part of this proposal I would also like to discuss the JDK
> vendors
> > >> we
> > >>>> are using on our CI platforms TeamCIty.
> > >>>> Historically, Ignite 2.x is being built under Oracle's edition -
> > mostly
> > >>>> because of some features like JFR or similar.
> > >>>> However today we have pretty much solid alternative represented by
> > >>> OpenJDK
> > >>>> and its most popular build Eclipse Temurin, which provides every
> > >> required
> > >>>> version for our needs (and especially LTS versions 1.8, 11 and 17)
> > with
> > >>> all
> > >>>> necessary updates.
> > >>>>
> > >>>> So, I suggest we update our build agents for TeamCity accordingly,
> > >>> provide
> > >>>> OpenJDK framework for those 3 major versions and discontinue
> Oracle's
> > >>>> builds.
> > >>>> WDYT?
> > >>>>
> > >>>> пт, 25 авг. 2023 г. в 12:13, Ivan Daschinsky <iv...@gmail.com>:
> > >>>>
> > >>>>> +1. It's time to do it at last.
> > >>>>>
> > >>>>> пт, 25 авг. 2023 г. в 12:06, Peter Ivanov <mr...@gmail.com>:
> > >>>>>
> > >>>>>> Mostly, yes.
> > >>>>>>
> > >>>>>> In other words - proposal is about starting shipping Apache Ignite
> > >>>>> releases
> > >>>>>> with JDK11 compiled binaries thus dropping JDK8-10 runtime
> support.
> > >>>>>>
> > >>>>>> пт, 25 авг. 2023 г. в 12:03, Anton Vinogradov <av...@apache.org>:
> > >>>>>>
> > >>>>>>> I looks like you're proposing not migration to 2.11 (because it
> > >> is
> > >>>>>> already
> > >>>>>>> supported), but Java 8-9 support dropping.
> > >>>>>>>
> > >>>>>>> On Fri, Aug 25, 2023 at 11:54 AM Peter Ivanov <
> > >> vveider@apache.org>
> > >>>>>> wrote:
> > >>>>>>>
> > >>>>>>>> Hi, Igniters!
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> I would like to propose the next, if you don't mind me saying,
> > >>>>>>>> revolutionary step forward in our project: moving Ignite 2.x
> > >>>>>> compilation
> > >>>>>>> to
> > >>>>>>>> JDK11 minimum version.
> > >>>>>>>> I'd rather not make arguments, pros and cons other that
> > >> currently
> > >>>>> exist
> > >>>>>>> in
> > >>>>>>>> Java world - you know them better than me. Let's just say that
> > >> it
> > >>>>> seems
> > >>>>>>>> that time has come - consider at least that JDK11 as the LTS
> > >>>> version
> > >>>>> is
> > >>>>>>>> already about 4 and a half years on the go, and Ignite 3.x
> > >>> started
> > >>>>> from
> > >>>>>>>> JDK11 right away.
> > >>>>>>>>
> > >>>>>>>> This change may possibly require from us additional efforts on
> > >>>>>> supporting
> > >>>>>>>> the last version with JDK8 in terms of releasing additional
> > >>> patches
> > >>>>> and
> > >>>>>>>> hotfixes a bit longer than usual. However, this is up to the
> > >>>>> community
> > >>>>>> to
> > >>>>>>>> decide.
> > >>>>>>>>
> > >>>>>>>> Currently, Apache Ignite 2.x (with Extensions as well) is
> > >> already
> > >>>>>>> prepared
> > >>>>>>>> for being compiled with JDK11 and almost all tests are passing.
> > >>> If
> > >>>> we
> > >>>>>>> come
> > >>>>>>>> to an agreement about this proposal and designate the next
> > >>> version
> > >>>>> that
> > >>>>>>>> will become the first to provide JDK11 compiled binaries - I am
> > >>>> ready
> > >>>>>> to
> > >>>>>>>> start the process of updating the TeamCity building project
> > >>>>>> accordingly.
> > >>>>>>>>
> > >>>>>>>>
> > >>>>>>>> Please, share your thoughts.
> > >>>>>>>>
> > >>>>>>>
> > >>>>>>
> > >>>>>
> > >>>>>
> > >>>>> --
> > >>>>> Sincerely yours, Ivan Daschinskiy
> > >>>>>
> > >>>>
> > >>>
> > >>>
> > >>> --
> > >>> Sincerely yours, Ivan Daschinskiy
> > >>>
> > >>
> >
> >
>

Re: [PROPOSAL] Move Ignite 2.x to JDK11 compilation

Posted by Maksim Timonin <ti...@apache.org>.
Hi, Igniters!

I suggest it's time to return to the discussion. There were 2 issues that
blocked the sources moving from jdk1.8 to jdk11 [1, 2] and they have now
been resolved. I have prepared a patch that changes maven.source.version to
11 and it passes MTCGA without blockers [3]. TeamCity already runs RunAll
every night under jdk11 [4], so changing the default java version should
not break anything.

I believe it's time we can make the move. The plan is as follows:

1. Conduct a vote "Move Ignite 2 sources to JDK11".
2. Upgrade all TeamCity jobs from jdk1.8 to jdk11.
3. Review and merge the patch [3] that changes `maven.source.version` in
Ignite's pom.xml to 11. This means that Apache Ignite 2.17 will be built
using jdk11.
4. Clean up all code that relies on jdk1.8.

Let's discuss this again. Peter, is there anything that needs to be done on
TeamCity before the upgrade?

[1] https://issues.apache.org/jira/browse/IGNITE-13202
[2] https://issues.apache.org/jira/browse/IGNITE-22671
[3] https://issues.apache.org/jira/browse/IGNITE-22669
[4]
https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_RunAll?mode=builds&tag=JDK_11

On Wed, Oct 25, 2023 at 4:15 AM Николай Ижиков <ni...@apache.org> wrote:

> +1
>
> > 24 окт. 2023 г., в 19:25, Anton Vinogradov <av...@apache.org> написал(а):
> >
> > ++1 for switch to the OpenJDK framework
> >
> > As to original question, I propose to (step-by-step):
> > 1) Switch to java 11 testing instead of 8
> > 2) Fix java 11 release
> > 3) Switch to maven.compiler.source 11 (Vote required)
> >
> > On Tue, Oct 24, 2023 at 7:12 PM Dmitriy Pavlov <dp...@apache.org>
> wrote:
> >
> >> ++1 for testing using JDK11
> >>
> >> +0 for switching off support of JDK8 runtimes and class version (unless
> >> compilation using JDK11 is done with -target=1.8 our users won't be
> able to
> >> run Ignite using Java 8).
> >>
> >> I suggest the following next steps: once tests are completely fine on
> >> Teamcity using JDK 11, we start a separate thread named like:
> >> "[VOTE] discontinuing JDK 8 since the 2.16 release"
> >> to make the issue for end users more obvious. Since Nikita volunteers
> to be
> >> a Release Manager, I suppose that 2.16 will be released quite soon.
> >>
> >> I personally prefer to switch to newer Java. Using newer runtime helps
> us
> >> to provide speed and scale, since JVM is developed all the time. But I
> >> might be unaware of the risks, so let's discuss it later with the entire
> >> dev community.
> >>
> >> Sincerely,
> >> Dmitriy Pavlov
> >>
> >> ср, 30 авг. 2023 г. в 19:09, Ivan Daschinsky <iv...@gmail.com>:
> >>
> >>> +1, sounds reasonable for the open source project. IMHO, Eclipse
> Temurin
> >>> JDK is a rule of thumb choice nowadays.
> >>>
> >>> ср, 30 авг. 2023 г. в 18:40, Peter Ivanov <mr...@gmail.com>:
> >>>
> >>>> Hi, Igniters!
> >>>>
> >>>> As part of this proposal I would also like to discuss the JDK vendors
> >> we
> >>>> are using on our CI platforms TeamCIty.
> >>>> Historically, Ignite 2.x is being built under Oracle's edition -
> mostly
> >>>> because of some features like JFR or similar.
> >>>> However today we have pretty much solid alternative represented by
> >>> OpenJDK
> >>>> and its most popular build Eclipse Temurin, which provides every
> >> required
> >>>> version for our needs (and especially LTS versions 1.8, 11 and 17)
> with
> >>> all
> >>>> necessary updates.
> >>>>
> >>>> So, I suggest we update our build agents for TeamCity accordingly,
> >>> provide
> >>>> OpenJDK framework for those 3 major versions and discontinue Oracle's
> >>>> builds.
> >>>> WDYT?
> >>>>
> >>>> пт, 25 авг. 2023 г. в 12:13, Ivan Daschinsky <iv...@gmail.com>:
> >>>>
> >>>>> +1. It's time to do it at last.
> >>>>>
> >>>>> пт, 25 авг. 2023 г. в 12:06, Peter Ivanov <mr...@gmail.com>:
> >>>>>
> >>>>>> Mostly, yes.
> >>>>>>
> >>>>>> In other words - proposal is about starting shipping Apache Ignite
> >>>>> releases
> >>>>>> with JDK11 compiled binaries thus dropping JDK8-10 runtime support.
> >>>>>>
> >>>>>> пт, 25 авг. 2023 г. в 12:03, Anton Vinogradov <av...@apache.org>:
> >>>>>>
> >>>>>>> I looks like you're proposing not migration to 2.11 (because it
> >> is
> >>>>>> already
> >>>>>>> supported), but Java 8-9 support dropping.
> >>>>>>>
> >>>>>>> On Fri, Aug 25, 2023 at 11:54 AM Peter Ivanov <
> >> vveider@apache.org>
> >>>>>> wrote:
> >>>>>>>
> >>>>>>>> Hi, Igniters!
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> I would like to propose the next, if you don't mind me saying,
> >>>>>>>> revolutionary step forward in our project: moving Ignite 2.x
> >>>>>> compilation
> >>>>>>> to
> >>>>>>>> JDK11 minimum version.
> >>>>>>>> I'd rather not make arguments, pros and cons other that
> >> currently
> >>>>> exist
> >>>>>>> in
> >>>>>>>> Java world - you know them better than me. Let's just say that
> >> it
> >>>>> seems
> >>>>>>>> that time has come - consider at least that JDK11 as the LTS
> >>>> version
> >>>>> is
> >>>>>>>> already about 4 and a half years on the go, and Ignite 3.x
> >>> started
> >>>>> from
> >>>>>>>> JDK11 right away.
> >>>>>>>>
> >>>>>>>> This change may possibly require from us additional efforts on
> >>>>>> supporting
> >>>>>>>> the last version with JDK8 in terms of releasing additional
> >>> patches
> >>>>> and
> >>>>>>>> hotfixes a bit longer than usual. However, this is up to the
> >>>>> community
> >>>>>> to
> >>>>>>>> decide.
> >>>>>>>>
> >>>>>>>> Currently, Apache Ignite 2.x (with Extensions as well) is
> >> already
> >>>>>>> prepared
> >>>>>>>> for being compiled with JDK11 and almost all tests are passing.
> >>> If
> >>>> we
> >>>>>>> come
> >>>>>>>> to an agreement about this proposal and designate the next
> >>> version
> >>>>> that
> >>>>>>>> will become the first to provide JDK11 compiled binaries - I am
> >>>> ready
> >>>>>> to
> >>>>>>>> start the process of updating the TeamCity building project
> >>>>>> accordingly.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Please, share your thoughts.
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Sincerely yours, Ivan Daschinskiy
> >>>>>
> >>>>
> >>>
> >>>
> >>> --
> >>> Sincerely yours, Ivan Daschinskiy
> >>>
> >>
>
>

Re: [PROPOSAL] Move Ignite 2.x to JDK11 compilation

Posted by Николай Ижиков <ni...@apache.org>.
+1

> 24 окт. 2023 г., в 19:25, Anton Vinogradov <av...@apache.org> написал(а):
> 
> ++1 for switch to the OpenJDK framework
> 
> As to original question, I propose to (step-by-step):
> 1) Switch to java 11 testing instead of 8
> 2) Fix java 11 release
> 3) Switch to maven.compiler.source 11 (Vote required)
> 
> On Tue, Oct 24, 2023 at 7:12 PM Dmitriy Pavlov <dp...@apache.org> wrote:
> 
>> ++1 for testing using JDK11
>> 
>> +0 for switching off support of JDK8 runtimes and class version (unless
>> compilation using JDK11 is done with -target=1.8 our users won't be able to
>> run Ignite using Java 8).
>> 
>> I suggest the following next steps: once tests are completely fine on
>> Teamcity using JDK 11, we start a separate thread named like:
>> "[VOTE] discontinuing JDK 8 since the 2.16 release"
>> to make the issue for end users more obvious. Since Nikita volunteers to be
>> a Release Manager, I suppose that 2.16 will be released quite soon.
>> 
>> I personally prefer to switch to newer Java. Using newer runtime helps us
>> to provide speed and scale, since JVM is developed all the time. But I
>> might be unaware of the risks, so let's discuss it later with the entire
>> dev community.
>> 
>> Sincerely,
>> Dmitriy Pavlov
>> 
>> ср, 30 авг. 2023 г. в 19:09, Ivan Daschinsky <iv...@gmail.com>:
>> 
>>> +1, sounds reasonable for the open source project. IMHO, Eclipse Temurin
>>> JDK is a rule of thumb choice nowadays.
>>> 
>>> ср, 30 авг. 2023 г. в 18:40, Peter Ivanov <mr...@gmail.com>:
>>> 
>>>> Hi, Igniters!
>>>> 
>>>> As part of this proposal I would also like to discuss the JDK vendors
>> we
>>>> are using on our CI platforms TeamCIty.
>>>> Historically, Ignite 2.x is being built under Oracle's edition - mostly
>>>> because of some features like JFR or similar.
>>>> However today we have pretty much solid alternative represented by
>>> OpenJDK
>>>> and its most popular build Eclipse Temurin, which provides every
>> required
>>>> version for our needs (and especially LTS versions 1.8, 11 and 17) with
>>> all
>>>> necessary updates.
>>>> 
>>>> So, I suggest we update our build agents for TeamCity accordingly,
>>> provide
>>>> OpenJDK framework for those 3 major versions and discontinue Oracle's
>>>> builds.
>>>> WDYT?
>>>> 
>>>> пт, 25 авг. 2023 г. в 12:13, Ivan Daschinsky <iv...@gmail.com>:
>>>> 
>>>>> +1. It's time to do it at last.
>>>>> 
>>>>> пт, 25 авг. 2023 г. в 12:06, Peter Ivanov <mr...@gmail.com>:
>>>>> 
>>>>>> Mostly, yes.
>>>>>> 
>>>>>> In other words - proposal is about starting shipping Apache Ignite
>>>>> releases
>>>>>> with JDK11 compiled binaries thus dropping JDK8-10 runtime support.
>>>>>> 
>>>>>> пт, 25 авг. 2023 г. в 12:03, Anton Vinogradov <av...@apache.org>:
>>>>>> 
>>>>>>> I looks like you're proposing not migration to 2.11 (because it
>> is
>>>>>> already
>>>>>>> supported), but Java 8-9 support dropping.
>>>>>>> 
>>>>>>> On Fri, Aug 25, 2023 at 11:54 AM Peter Ivanov <
>> vveider@apache.org>
>>>>>> wrote:
>>>>>>> 
>>>>>>>> Hi, Igniters!
>>>>>>>> 
>>>>>>>> 
>>>>>>>> I would like to propose the next, if you don't mind me saying,
>>>>>>>> revolutionary step forward in our project: moving Ignite 2.x
>>>>>> compilation
>>>>>>> to
>>>>>>>> JDK11 minimum version.
>>>>>>>> I'd rather not make arguments, pros and cons other that
>> currently
>>>>> exist
>>>>>>> in
>>>>>>>> Java world - you know them better than me. Let's just say that
>> it
>>>>> seems
>>>>>>>> that time has come - consider at least that JDK11 as the LTS
>>>> version
>>>>> is
>>>>>>>> already about 4 and a half years on the go, and Ignite 3.x
>>> started
>>>>> from
>>>>>>>> JDK11 right away.
>>>>>>>> 
>>>>>>>> This change may possibly require from us additional efforts on
>>>>>> supporting
>>>>>>>> the last version with JDK8 in terms of releasing additional
>>> patches
>>>>> and
>>>>>>>> hotfixes a bit longer than usual. However, this is up to the
>>>>> community
>>>>>> to
>>>>>>>> decide.
>>>>>>>> 
>>>>>>>> Currently, Apache Ignite 2.x (with Extensions as well) is
>> already
>>>>>>> prepared
>>>>>>>> for being compiled with JDK11 and almost all tests are passing.
>>> If
>>>> we
>>>>>>> come
>>>>>>>> to an agreement about this proposal and designate the next
>>> version
>>>>> that
>>>>>>>> will become the first to provide JDK11 compiled binaries - I am
>>>> ready
>>>>>> to
>>>>>>>> start the process of updating the TeamCity building project
>>>>>> accordingly.
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Please, share your thoughts.
>>>>>>>> 
>>>>>>> 
>>>>>> 
>>>>> 
>>>>> 
>>>>> --
>>>>> Sincerely yours, Ivan Daschinskiy
>>>>> 
>>>> 
>>> 
>>> 
>>> --
>>> Sincerely yours, Ivan Daschinskiy
>>> 
>> 


Re: [PROPOSAL] Move Ignite 2.x to JDK11 compilation

Posted by Anton Vinogradov <av...@apache.org>.
++1 for switch to the OpenJDK framework

As to original question, I propose to (step-by-step):
1) Switch to java 11 testing instead of 8
2) Fix java 11 release
3) Switch to maven.compiler.source 11 (Vote required)

On Tue, Oct 24, 2023 at 7:12 PM Dmitriy Pavlov <dp...@apache.org> wrote:

> ++1 for testing using JDK11
>
> +0 for switching off support of JDK8 runtimes and class version (unless
> compilation using JDK11 is done with -target=1.8 our users won't be able to
> run Ignite using Java 8).
>
> I suggest the following next steps: once tests are completely fine on
> Teamcity using JDK 11, we start a separate thread named like:
> "[VOTE] discontinuing JDK 8 since the 2.16 release"
> to make the issue for end users more obvious. Since Nikita volunteers to be
> a Release Manager, I suppose that 2.16 will be released quite soon.
>
> I personally prefer to switch to newer Java. Using newer runtime helps us
> to provide speed and scale, since JVM is developed all the time. But I
> might be unaware of the risks, so let's discuss it later with the entire
> dev community.
>
> Sincerely,
> Dmitriy Pavlov
>
> ср, 30 авг. 2023 г. в 19:09, Ivan Daschinsky <iv...@gmail.com>:
>
> > +1, sounds reasonable for the open source project. IMHO, Eclipse Temurin
> > JDK is a rule of thumb choice nowadays.
> >
> > ср, 30 авг. 2023 г. в 18:40, Peter Ivanov <mr...@gmail.com>:
> >
> > > Hi, Igniters!
> > >
> > > As part of this proposal I would also like to discuss the JDK vendors
> we
> > > are using on our CI platforms TeamCIty.
> > > Historically, Ignite 2.x is being built under Oracle's edition - mostly
> > > because of some features like JFR or similar.
> > > However today we have pretty much solid alternative represented by
> > OpenJDK
> > > and its most popular build Eclipse Temurin, which provides every
> required
> > > version for our needs (and especially LTS versions 1.8, 11 and 17) with
> > all
> > > necessary updates.
> > >
> > > So, I suggest we update our build agents for TeamCity accordingly,
> > provide
> > > OpenJDK framework for those 3 major versions and discontinue Oracle's
> > > builds.
> > > WDYT?
> > >
> > > пт, 25 авг. 2023 г. в 12:13, Ivan Daschinsky <iv...@gmail.com>:
> > >
> > > > +1. It's time to do it at last.
> > > >
> > > > пт, 25 авг. 2023 г. в 12:06, Peter Ivanov <mr...@gmail.com>:
> > > >
> > > > > Mostly, yes.
> > > > >
> > > > > In other words - proposal is about starting shipping Apache Ignite
> > > > releases
> > > > > with JDK11 compiled binaries thus dropping JDK8-10 runtime support.
> > > > >
> > > > > пт, 25 авг. 2023 г. в 12:03, Anton Vinogradov <av...@apache.org>:
> > > > >
> > > > > > I looks like you're proposing not migration to 2.11 (because it
> is
> > > > > already
> > > > > > supported), but Java 8-9 support dropping.
> > > > > >
> > > > > > On Fri, Aug 25, 2023 at 11:54 AM Peter Ivanov <
> vveider@apache.org>
> > > > > wrote:
> > > > > >
> > > > > > > Hi, Igniters!
> > > > > > >
> > > > > > >
> > > > > > > I would like to propose the next, if you don't mind me saying,
> > > > > > > revolutionary step forward in our project: moving Ignite 2.x
> > > > > compilation
> > > > > > to
> > > > > > > JDK11 minimum version.
> > > > > > > I'd rather not make arguments, pros and cons other that
> currently
> > > > exist
> > > > > > in
> > > > > > > Java world - you know them better than me. Let's just say that
> it
> > > > seems
> > > > > > > that time has come - consider at least that JDK11 as the LTS
> > > version
> > > > is
> > > > > > > already about 4 and a half years on the go, and Ignite 3.x
> > started
> > > > from
> > > > > > > JDK11 right away.
> > > > > > >
> > > > > > > This change may possibly require from us additional efforts on
> > > > > supporting
> > > > > > > the last version with JDK8 in terms of releasing additional
> > patches
> > > > and
> > > > > > > hotfixes a bit longer than usual. However, this is up to the
> > > > community
> > > > > to
> > > > > > > decide.
> > > > > > >
> > > > > > > Currently, Apache Ignite 2.x (with Extensions as well) is
> already
> > > > > > prepared
> > > > > > > for being compiled with JDK11 and almost all tests are passing.
> > If
> > > we
> > > > > > come
> > > > > > > to an agreement about this proposal and designate the next
> > version
> > > > that
> > > > > > > will become the first to provide JDK11 compiled binaries - I am
> > > ready
> > > > > to
> > > > > > > start the process of updating the TeamCity building project
> > > > > accordingly.
> > > > > > >
> > > > > > >
> > > > > > > Please, share your thoughts.
> > > > > > >
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Sincerely yours, Ivan Daschinskiy
> > > >
> > >
> >
> >
> > --
> > Sincerely yours, Ivan Daschinskiy
> >
>