You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/06 12:39:17 UTC
[GitHub] [rocketmq] caigy opened a new issue #3587: Unnecessary boxing of primitives in org.apache.rocketmq.broker.transaction.queue.TransactionalMessageServiceImpl
caigy opened a new issue #3587:
URL: https://github.com/apache/rocketmq/issues/3587
In method `private Long getLong(String s)` and `private Integer getInt(String s)` of `org.apache.rocketmq.broker.transaction.queue.TransactionalMessageServiceImpl`, a boxed numeric primitive is created from `String`, and then unboxed.
For example, ` v = Integer.valueOf(s)` (`v` is of type `int`), it would be more efficient to use `Integer.parseInt()`, which returns a primitive value directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShannonDing closed issue #3587: Unnecessary boxing of primitives in org.apache.rocketmq.broker.transaction.queue.TransactionalMessageServiceImpl
Posted by GitBox <gi...@apache.org>.
ShannonDing closed issue #3587:
URL: https://github.com/apache/rocketmq/issues/3587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] ShannonDing commented on issue #3587: Unnecessary boxing of primitives in org.apache.rocketmq.broker.transaction.queue.TransactionalMessageServiceImpl
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on issue #3587:
URL: https://github.com/apache/rocketmq/issues/3587#issuecomment-989451691
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zhaohai1299002788 commented on issue #3587: Unnecessary boxing of primitives in org.apache.rocketmq.broker.transaction.queue.TransactionalMessageServiceImpl
Posted by GitBox <gi...@apache.org>.
zhaohai1299002788 commented on issue #3587:
URL: https://github.com/apache/rocketmq/issues/3587#issuecomment-987534927
#3596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org