You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2026/09/09 21:51:53 UTC

[kudu-CR] [misc] fix compilation warnings with GCC-15 on CWG #2237

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24809


Change subject: [misc] fix compilation warnings with GCC-15 on CWG #2237
......................................................................

[misc] fix compilation warnings with GCC-15 on CWG #2237

Since GCC-15 implemented the resolution on CWG Issue 2237 [1], there
was a flood of warnings like below when compiling with GCC-15.  This
changelist addresses the issue.

  src/kudu/gutil/macros.h:98:11: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
     98 |   TypeName(const TypeName&) = delete;      \
        |           ^
  src/kudu/gutil/ref_counted.h:102:3: note: in expansion of macro ‘DISALLOW_COPY_AND_ASSIGN’
    102 |   DISALLOW_COPY_AND_ASSIGN(RefCounted<T>);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~
  src/kudu/gutil/macros.h:98:11: note: remove the ‘< >’

This changelist doesn't contain any functional modifications.

[1] https://cplusplus.github.io/CWG/issues/2237.html

Change-Id: Idb863c8cf547d6da79489944269f0c257de7411b
---
M src/kudu/common/key_encoder.cc
M src/kudu/gutil/ref_counted.h
M src/kudu/gutil/stl_util.h
3 files changed, 10 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/24809/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb863c8cf547d6da79489944269f0c257de7411b
Gerrit-Change-Number: 24809
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [misc] fix compilation warnings with GCC-15 on CWG #2237

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24809 )

Change subject: [misc] fix compilation warnings with GCC-15 on CWG #2237
......................................................................

[misc] fix compilation warnings with GCC-15 on CWG #2237

Since GCC-15 implemented the resolution on CWG Issue 2237 [1], there
was a flood of warnings like below when compiling with GCC-15.  This
changelist addresses the issue.

  src/kudu/gutil/macros.h:98:11: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
     98 |   TypeName(const TypeName&) = delete;      \
        |           ^
  src/kudu/gutil/ref_counted.h:102:3: note: in expansion of macro ‘DISALLOW_COPY_AND_ASSIGN’
    102 |   DISALLOW_COPY_AND_ASSIGN(RefCounted<T>);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~
  src/kudu/gutil/macros.h:98:11: note: remove the ‘< >’

This changelist doesn't contain any functional modifications.

[1] https://cplusplus.github.io/CWG/issues/2237.html

Change-Id: Idb863c8cf547d6da79489944269f0c257de7411b
Reviewed-on: http://gerrit.cloudera.org:8080/24809
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Martonka <zm...@cloudera.com>
---
M src/kudu/common/key_encoder.cc
M src/kudu/gutil/ref_counted.h
M src/kudu/gutil/stl_util.h
3 files changed, 10 insertions(+), 10 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Zoltan Martonka: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/24809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb863c8cf547d6da79489944269f0c257de7411b
Gerrit-Change-Number: 24809
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [misc] fix compilation warnings with GCC-15 on CWG #2237

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24809 )

Change subject: [misc] fix compilation warnings with GCC-15 on CWG #2237
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/2947/


-- 
To view, visit http://gerrit.cloudera.org:8080/24809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb863c8cf547d6da79489944269f0c257de7411b
Gerrit-Change-Number: 24809
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 09 Sep 2026 21:52:00 +0000
Gerrit-HasComments: No

[kudu-CR] [misc] fix compilation warnings with GCC-15 on CWG #2237

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24809 )

Change subject: [misc] fix compilation warnings with GCC-15 on CWG #2237
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb863c8cf547d6da79489944269f0c257de7411b
Gerrit-Change-Number: 24809
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Sep 2026 17:02:28 +0000
Gerrit-HasComments: No

[kudu-CR] [misc] fix compilation warnings with GCC-15 on CWG #2237

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24809 )

Change subject: [misc] fix compilation warnings with GCC-15 on CWG #2237
......................................................................


Patch Set 1: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/2947/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/24809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb863c8cf547d6da79489944269f0c257de7411b
Gerrit-Change-Number: 24809
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Sep 2026 22:42:27 +0000
Gerrit-HasComments: No

[kudu-CR] [misc] fix compilation warnings with GCC-15 on CWG #2237

Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24809 )

Change subject: [misc] fix compilation warnings with GCC-15 on CWG #2237
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb863c8cf547d6da79489944269f0c257de7411b
Gerrit-Change-Number: 24809
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Sep 2026 06:18:03 +0000
Gerrit-HasComments: No