You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Alexey Zotov (JIRA)" <ji...@apache.org> on 2012/09/12 16:13:08 UTC

[jira] [Created] (CASSANDRA-4656) StorageProxy histograms

Alexey Zotov created CASSANDRA-4656:
---------------------------------------

             Summary: StorageProxy histograms
                 Key: CASSANDRA-4656
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
             Project: Cassandra
          Issue Type: Improvement
          Components: Core
    Affects Versions: 1.1.4
            Reporter: Alexey Zotov
            Priority: Minor


I suggest to do two improvements:
1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).

2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.

Old output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597                                 0               505                 0                 0
1916                                 0               566                 0                 0
{code}

New output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597            0                      0               505                 0                 0
1916            0                     0               566                 0                 0
{code}


PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-4656:
--------------------------------------

    Reviewer: brandon.williams  (was: yukim)
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms_with_empty_values_v11.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment: cassandra-1.1-4656-histograms_with_empty_values.txt
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: cassandra-1.1-4656-histograms_with_empty_values.txt, cassandra-1.2-4656-empty_values.txt
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Assigned] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov reassigned CASSANDRA-4656:
---------------------------------------

    Assignee: Alexey Zotov
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Assignee: Alexey Zotov
>            Priority: Minor
>             Fix For: 1.1.6
>
>         Attachments: cassandra-1.1-4656-histograms_with_empty_values.txt, cassandra-1.2-4656-empty_values.txt
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment: cassandra-1.2-4656-empty_values.txt
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: cassandra-1.1-4656-histograms_with_empty_values.txt, cassandra-1.2-4656-empty_values.txt
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-4656:
--------------------------------------

    Reviewer: yukim
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: StorageProxy_histograms.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Description: 
I suggest to do two improvements:
1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).

2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.

Old output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597                                 0               505                 0                 0
1916                                 0               566                 0                 0
{code}

New output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597            0                     0               505                 0                 0
1916            0                     0               566                 0                 0
{code}


PS: I've attached a patch that fixes all described problems. 

  was:
I suggest to do two improvements:
1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).

2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.

Old output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597                                 0               505                 0                 0
1916                                 0               566                 0                 0
{code}

New output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597            0                      0               505                 0                 0
1916            0                     0               566                 0                 0
{code}


PS: I've attached a patch that fixes all described problems. 

    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597            0                     0               505                 0                 0
> 1916            0                     0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455217#comment-13455217 ] 

Alexey Zotov commented on CASSANDRA-4656:
-----------------------------------------

Brandon, thanks for response. 
I've found your changes and created patch (Empty_values_in_histograms_v12.patch) with fixes about replacing empty values by '0'. 
I think backporting is not necessary, but I can do it. Should I create patch with your changes (about proxyhistograms) and my changes (about replacing empty values by '0') for 1.1 version?
                
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Description: 
I suggest to do two improvements:
1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).

2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.

Old output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597                                 0               505                 0                 0
1916                                 0               566                 0                 0
{code}

New output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597               0                 0               505                 0                 0
1916               0                 0               566                 0                 0
{code}


PS: I've attached a patch that fixes all described problems. 

  was:
I suggest to do two improvements:
1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).

2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.

Old output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597                                 0               505                 0                 0
1916                                 0               566                 0                 0
{code}

New output:
{code}
Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
1             109298                 0                 0                 0         128700943
2                778                 0                 0                 0                 0
....
1597            0                     0               505                 0                 0
1916            0                     0               566                 0                 0
{code}


PS: I've attached a patch that fixes all described problems. 

    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: StorageProxy_histograms.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment: StorageProxy_histograms_with_empty_values_v11.patch
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms_with_empty_values_v11.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment:     (was: StorageProxy_histograms_with_empty_values_v11.patch)
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: cassandra-1.1-4656-histograms_with_empty_values.txt, cassandra-1.2-4656-empty_values.txt
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment: StorageProxy_histograms.patch
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: StorageProxy_histograms.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment: Empty_values_in_histograms_v12.patch
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment:     (was: StorageProxy_histograms_with_empty_values_v11.patch)
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms_with_empty_values_v11.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4656) StorageProxy histograms

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454101#comment-13454101 ] 

Brandon Williams commented on CASSANDRA-4656:
---------------------------------------------

In CASSANDRA-3722 I added similar functionality (nodetool proxyhistograms), but that's only in 1.2. I suggest backporting that if this is targeting 1.1 to make merging easier.
                
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: StorageProxy_histograms.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456915#comment-13456915 ] 

Alexey Zotov commented on CASSANDRA-4656:
-----------------------------------------

I've backported 'nodetool proxyhistograms' functionality to 1.1 version. All patches are attached.
                
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms_with_empty_values_v11.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment:     (was: cassandra-1.2-4656-empty_values.tx)
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: cassandra-1.1-4656-histograms_with_empty_values.txt, cassandra-1.2-4656-empty_values.txt
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4656) StorageProxy histograms

Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455239#comment-13455239 ] 

Brandon Williams commented on CASSANDRA-4656:
---------------------------------------------

I'd be fine with putting proxyhistograms in 1.1 if you'd like.
                
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment: StorageProxy_histograms_with_empty_values_v11.patch
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms_with_empty_values_v11.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment: cassandra-1.2-4656-empty_values.tx
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: cassandra-1.1-4656-histograms_with_empty_values.txt, cassandra-1.2-4656-empty_values.txt
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458438#comment-13458438 ] 

Alexey Zotov commented on CASSANDRA-4656:
-----------------------------------------

Patches have been recreated using git instead of intellij idea. 
                
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: cassandra-1.1-4656-histograms_with_empty_values.txt, cassandra-1.2-4656-empty_values.txt
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment:     (was: Empty_values_in_histograms_v12.patch)
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: cassandra-1.1-4656-histograms_with_empty_values.txt, cassandra-1.2-4656-empty_values.txt
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-4656) StorageProxy histograms

Posted by "Alexey Zotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-4656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Zotov updated CASSANDRA-4656:
------------------------------------

    Attachment:     (was: StorageProxy_histograms.patch)
    
> StorageProxy histograms
> -----------------------
>
>                 Key: CASSANDRA-4656
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-4656
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.4
>            Reporter: Alexey Zotov
>            Priority: Minor
>         Attachments: Empty_values_in_histograms_v12.patch, StorageProxy_histograms_with_empty_values_v11.patch
>
>
> I suggest to do two improvements:
> 1. StorageProxy histograms need to be added to the cli. In my opinion that statistic is very important, because it shows real server response time (with accounting of additional requests to other nodes). It can be usefull for gathering of the server response time statistics by some monitoring systems (without using additional JMX modules).
> 2. Output of 'nodetool cfhistograms' command has an empty values in 'SSTables' column. Output is not usable for parse because of that. I suggest to insert '0' instead of empty values.
> Old output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597                                 0               505                 0                 0
> 1916                                 0               566                 0                 0
> {code}
> New output:
> {code}
> Offset      SSTables     Write Latency      Read Latency          Row Size      Column Count
> 1             109298                 0                 0                 0         128700943
> 2                778                 0                 0                 0                 0
> ....
> 1597               0                 0               505                 0                 0
> 1916               0                 0               566                 0                 0
> {code}
> PS: I've attached a patch that fixes all described problems. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira