You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Thomas Koch (JIRA)" <ji...@apache.org> on 2011/09/14 11:43:09 UTC
[jira] [Created] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Make findbugs usable in Eclipse
-------------------------------
Key: ZOOKEEPER-1182
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
Project: ZooKeeper
Issue Type: Task
Reporter: Thomas Koch
Assignee: Thomas Koch
Priority: Minor
I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104994#comment-13104994 ]
Hadoop QA commented on ZOOKEEPER-1182:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494515/ZOOKEEPER-1182.patch
against trunk revision 1170886.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 69 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/541//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/541//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/541//console
This message is automatically generated.
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch, ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1182:
-----------------------------------
Attachment: ZOOKEEPER-1182.patch
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104902#comment-13104902 ]
Hadoop QA commented on ZOOKEEPER-1182:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494515/ZOOKEEPER-1182.patch
against trunk revision 1170458.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 69 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/537//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/537//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/537//console
This message is automatically generated.
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch, ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107084#comment-13107084 ]
Hudson commented on ZOOKEEPER-1182:
-----------------------------------
Integrated in ZooKeeper-trunk #1306 (See [https://builds.apache.org/job/ZooKeeper-trunk/1306/])
ZOOKEEPER-1182. Make findbugs usable in Eclipse (Thomas Koch via phunt)
phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171869
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/JUnit4ZKTestRunner.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ChrootTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientBase.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ClientHammerTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLERestartTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLETest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MaxCnxnsTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/QuorumUtil.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SledgeHammer.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/UpgradeTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/WatchedEventTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/WatcherTest.java
* /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch, ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104936#comment-13104936 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1182:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1880/
-----------------------------------------------------------
(Updated 2011-09-14 22:16:33.632963)
Review request for zookeeper.
Summary (updated)
-------
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch, ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-1182:
------------------------------------
Fix Version/s: 3.5.0
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104415#comment-13104415 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1182:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1880/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "Thomas Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Koch updated ZOOKEEPER-1182:
-----------------------------------
Attachment: ZOOKEEPER-1182.patch
changed longs to Longs as suggested in Patrick's review.
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch, ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104650#comment-13104650 ]
Hadoop QA commented on ZOOKEEPER-1182:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12494421/ZOOKEEPER-1182.patch
against trunk revision 1170458.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 69 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/535//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/535//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/535//console
This message is automatically generated.
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Attachments: ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104772#comment-13104772 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1182:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1880/#review1897
-----------------------------------------------------------
lgtm. I'm personally in favor of moving to guava if that floats your boat (future patches). It came up briefly during the postsummit meetup and ppl seemed generally in favor.
btw: please mention the JIRA # in the summary. e.g. "ZOOKEEPER-1234 <jira summary text>"
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
<https://reviews.apache.org/r/1880/#comment4380>
1L ?
src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
<https://reviews.apache.org/r/1880/#comment4381>
2L ?
- Patrick
On 2011-09-14 11:07:49, Thomas Koch wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1880/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 11:07:49)
bq.
bq.
bq. Review request for zookeeper.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. .
bq.
bq.
bq. This addresses bug ZOOKEEPER-1182.
bq. https://issues.apache.org/jira/browse/ZOOKEEPER-1182
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/test/org/apache/zookeeper/JUnit4ZKTestRunner.java 188c9f7
bq. src/java/test/org/apache/zookeeper/server/quorum/LearnerTest.java 7419510
bq. src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java 45a61c7
bq. src/java/test/org/apache/zookeeper/test/ChrootTest.java 3df068b
bq. src/java/test/org/apache/zookeeper/test/ClientBase.java 0fc7d25
bq. src/java/test/org/apache/zookeeper/test/ClientHammerTest.java 581402c
bq. src/java/test/org/apache/zookeeper/test/CnxManagerTest.java fed68c1
bq. src/java/test/org/apache/zookeeper/test/FLELostMessageTest.java 98f8e10
bq. src/java/test/org/apache/zookeeper/test/FLERestartTest.java f092563
bq. src/java/test/org/apache/zookeeper/test/FLETest.java f1e050d
bq. src/java/test/org/apache/zookeeper/test/FLEZeroWeightTest.java f3d1316
bq. src/java/test/org/apache/zookeeper/test/LENonTerminateTest.java 3658714
bq. src/java/test/org/apache/zookeeper/test/LoadFromLogTest.java d92f2d3
bq. src/java/test/org/apache/zookeeper/test/MaxCnxnsTest.java 38e84fa
bq. src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java fa9c8f3
bq. src/java/test/org/apache/zookeeper/test/QuorumTest.java 13d0e83
bq. src/java/test/org/apache/zookeeper/test/QuorumUtil.java a68ebec
bq. src/java/test/org/apache/zookeeper/test/SledgeHammer.java 614a93d
bq. src/java/test/org/apache/zookeeper/test/StaticHostProviderTest.java fa0128c
bq. src/java/test/org/apache/zookeeper/test/UpgradeTest.java b8db0da
bq. src/java/test/org/apache/zookeeper/test/WatchedEventTest.java 0eaea67
bq. src/java/test/org/apache/zookeeper/test/WatcherTest.java 90ec513
bq. src/java/test/org/apache/zookeeper/test/ZooKeeperTestClient.java 67ca52f
bq.
bq. Diff: https://reviews.apache.org/r/1880/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Thomas
bq.
bq.
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1182) Make findbugs usable in Eclipse
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104879#comment-13104879 ]
jiraposter@reviews.apache.org commented on ZOOKEEPER-1182:
----------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1880/
-----------------------------------------------------------
(Updated 2011-09-14 21:08:55.602918)
Review request for zookeeper.
Changes
-------
changed longs to Longs as suggested
Summary
-------
> Make findbugs usable in Eclipse
> -------------------------------
>
> Key: ZOOKEEPER-1182
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1182
> Project: ZooKeeper
> Issue Type: Task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Priority: Minor
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1182.patch, ZOOKEEPER-1182.patch
>
>
> I did not find any way how one could tell the eclipse findbugs extension to ignore the java files under src/java/test. I already use src/java/test/config/findbugsExcludeFile.xml but there are still many findbug warnings.
> So this patch solves the most obvious findbugs warnings under src/java/test. There are 30 remaining warnings which could either be ignored in the exclude file or solved by somebody with more knowledge about the code.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira