You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/11/10 13:39:50 UTC
[GitHub] [daffodil] pkatlic opened a new pull request, #872: Add macOS build support
pkatlic opened a new pull request, #872:
URL: https://github.com/apache/daffodil/pull/872
Add build documentation and update code to support building on macOS. Rename existing stack_t struct to avoid conflict with built-in type definition on macO. Use int64 and uint64 primitives for integer types to fix compilation warnings. Add portable endian header file for macOS endian definitions, as these are not located in endian.h. This was tested on macOS 10.15.7.
DAFFODIL-2744
BUILD.md: Add macOS dependency installation to build documentation.
stack.h: Rename stack_t struct to c_stack_t in order to avoid naming conflict with macOS types.
stack.c: Rename stack_t struct to c_stack_t in order to avoid naming conflict with macOS types.
xml_writer.h: Rename stack_t struct to c_stack_t in order to avoid naming conflict with macOS types.
xml_writer.c: Use PRIi64 and PRIu64 integer types to avoid compilation warnings on macOS.
p_endian.h: Add portable endian header file for including proper endian header files and defines on macOS.
parsers.c: Import portable endian header file.
unparsers.c: Import portable endian header file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on pull request #872: Add macOS build support
Posted by GitBox <gi...@apache.org>.
tuxji commented on PR #872:
URL: https://github.com/apache/daffodil/pull/872#issuecomment-1310443027
> I think this is a question for other devs: should we consider adding a GitHub action for macOS to ensure this continues to work?
Peter and I certainly can modify the GitHub Actions CI workflow if anyone else would like macOS support. If we do so, I propose that we run only one job on the macOS runner (that is, we don't test Java 8, 11, and 17 since that would be redundant with the Linux and Windows runners already testing Java 8, 11, and 17). I have been using Java 11 as my machine's Java runtime up to now, but googling makes me think our choice really should be between Java 8 (if we want to support the most widely used Java runtime) or Java 17 (if we want to support the current LTS version and Java 17 was released over 1 year ago, so it's had enough time to fix bugs and become a stable runtime). Shall we test only Java 17 on the macOS runner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #872: Add macOS build support
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #872:
URL: https://github.com/apache/daffodil/pull/872#issuecomment-1310423337
> > I think this is a question for other devs: should we consider adding a GitHub action for macOS to ensure this continues to work?
>
> Yes, but not as part of this ticket, but another one about specifically setting that up.
Agreed it can be done separately. I've created [DAFFODIL-2747](https://issues.apache.org/jira/browse/DAFFODIL-2747) for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] mbeckerle commented on pull request #872: Add macOS build support
Posted by GitBox <gi...@apache.org>.
mbeckerle commented on PR #872:
URL: https://github.com/apache/daffodil/pull/872#issuecomment-1310418910
> I think this is a question for other devs: should we consider adding a GitHub action for macOS to ensure this continues to work?
Yes, but not as part of this ticket, but another one about specifically setting that up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] stevedlawrence commented on pull request #872: Add macOS build support
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on PR #872:
URL: https://github.com/apache/daffodil/pull/872#issuecomment-1310420953
> The Build Documentation step generates 1 warning
There's lots of discussions on the internet about this error, with I think no real resolution. I think this might be a known issue.
> The Run Integration Tests step now generates 3 warnings;
This was a change made in the recent integration test refactoring. We used to just have the blob tests commented out because they require manually generating large files to test. But because they were commented out, they were easy to forget about. To avoid that, I added some JUnit `assumeTrue` calls so that the tests would be skipped if those generated files didn't exist. That way the tests still pass, but we get a clear reminder that those tests exist and were skipped. We don't need to run these very often because blob logic doesn't change much, but they're good to know have be periodically reminded of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji commented on pull request #872: Add macOS build support
Posted by GitBox <gi...@apache.org>.
tuxji commented on PR #872:
URL: https://github.com/apache/daffodil/pull/872#issuecomment-1310448621
I'll move our discussion about Java runtimes to [DAFFODIL-2747](https://issues.apache.org/jira/browse/DAFFODIL-2747).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil] tuxji merged pull request #872: Add macOS build support
Posted by GitBox <gi...@apache.org>.
tuxji merged PR #872:
URL: https://github.com/apache/daffodil/pull/872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org