You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "sigalite (via GitHub)" <gi...@apache.org> on 2023/04/13 14:03:44 UTC

[GitHub] [flink] sigalite opened a new pull request, #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

sigalite opened a new pull request, #22393:
URL: https://github.com/apache/flink/pull/22393

   ## What is the purpose of the change
   enable the job manager and task manager communicate in a Kubernetes cluster with Istio and mTLS enabled.
   
   
   *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
   
   
   ## Brief change log
   Add the “appProtocol” in the task manager and job manager configuration, verify they are not overridden by the default definition in the decorators
   
   ## Verifying this change
   This change is already covered by existing tests
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency):  no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`:  no
     - The serializers: no 
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? not sure
     - If yes, how is the feature documented? not documented
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] CasperTDK commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "CasperTDK (via GitHub)" <gi...@apache.org>.
CasperTDK commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1600537399

   Allowing myself to give this a bump. Any way to prioritize the review?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1507043111

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f9d940ab5bb355f5174a6377948d4e1f7a7d00c2",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f9d940ab5bb355f5174a6377948d4e1f7a7d00c2",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f9d940ab5bb355f5174a6377948d4e1f7a7d00c2 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MosheElisha commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "MosheElisha (via GitHub)" <gi...@apache.org>.
MosheElisha commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1510138618

   LGTM! Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sigalite commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "sigalite (via GitHub)" <gi...@apache.org>.
sigalite commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1618480630

   please review https://github.com/apache/flink/pull/22936
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sigalite commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "sigalite (via GitHub)" <gi...@apache.org>.
sigalite commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1525791232

   added unit tests. thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sigalite commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "sigalite (via GitHub)" <gi...@apache.org>.
sigalite commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1568145290

   @wangyang0918 can you please review. thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1618038692

   @sigalite I think you'll need to rebase and squash your commits, since your PR contains merge commits and it can't be merged as-is. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1618157721

   @sigalite You're merging the branch into your PR, but you need to rebase. There's shouldn't be any "merge into" commits in your PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sigalite closed pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "sigalite (via GitHub)" <gi...@apache.org>.
sigalite closed pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion
URL: https://github.com/apache/flink/pull/22393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sigalite commented on pull request #22393: FLINK-28171 [flink-kubernates] enable add appProtocol via the configuration and verify it is not overridden by Default port defintion

Posted by "sigalite (via GitHub)" <gi...@apache.org>.
sigalite commented on PR #22393:
URL: https://github.com/apache/flink/pull/22393#issuecomment-1618479407

   Thanks @MartijnVisser, i'm afraid i had issues withe rebase and squashe. created new PR
   https://github.com/apache/flink/pull/22936
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org