You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/02/29 16:58:07 UTC
[GitHub] cordova-windows pull request: CB-10730 Move plugin handlers tests ...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/155
CB-10730 Move plugin handlers tests for into platform's repo
JIRA: https://issues.apache.org/jira/browse/CB-10730
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-10730
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit a6061459e4ea6c795fe77c2491e64741e6b888a6
Author: Vladimir Kotikov <ko...@gmail.com>
Date: 2016-02-29T14:37:37Z
CB-10730 Move plugin handlers tests for into platform's repo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10730 Move plugin handlers tests ...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/155#discussion_r54820656
--- Diff: spec/unit/JsprojManager.spec.js ---
@@ -53,6 +54,13 @@ describe('JsprojManager', function () {
JsprojManager.__set__('proj', origProj);
});
+ it('should throw if project is not an windows project', function () {
--- End diff --
`"... not a windows ..."`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10730 Move plugin handlers tests ...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-windows/pull/155#issuecomment-191521522
Is there also a PR for removing these from `cordova-lib`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10730 Move plugin handlers tests ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/155#discussion_r54697909
--- Diff: spec/unit/JsprojManager.spec.js ---
@@ -25,6 +25,7 @@ var AppxManifest = require('../../template/cordova/lib/AppxManifest');
var JsprojManager = rewire('../../template/cordova/lib/JsprojManager');
var PROJECT_PATH = 'spec/unit/fixtures/EmptyProject';
--- End diff --
Updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10730 Move plugin handlers tests ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/155
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10730 Move plugin handlers tests ...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/155#discussion_r54650191
--- Diff: spec/unit/JsprojManager.spec.js ---
@@ -25,6 +25,7 @@ var AppxManifest = require('../../template/cordova/lib/AppxManifest');
var JsprojManager = rewire('../../template/cordova/lib/JsprojManager');
var PROJECT_PATH = 'spec/unit/fixtures/EmptyProject';
--- End diff --
Should this be `DummyProject`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10730 Move plugin handlers tests ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/155#issuecomment-191624625
> Is there also a PR for removing these from cordova-lib?
No, because the code these tests are testing is still in cordova-lib. I think we could remove the tests along with the code as a part of PlatformApi polyfill deprecation (see [CB-10644](https://issues.apache.org/jira/browse/CB-10644) and corresponding [mailing list discussion](http://markmail.org/thread/b5j4mhvnxws7jbgk) )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org