You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2019/08/25 16:08:57 UTC
[GitHub] [knox] smolnar82 opened a new pull request #134: KNOX-1934 -
Setting the default value of knoxsso.cookie.secure.only based on
ssl.enabled flag in gateway-site.xml
smolnar82 opened a new pull request #134: KNOX-1934 - Setting the default value of knoxsso.cookie.secure.only based on ssl.enabled flag in gateway-site.xml
URL: https://github.com/apache/knox/pull/134
## What changes were proposed in this pull request?
In case the `knoxsso.cookie.secure.only` is not set we use the value of `ssl.enabled` flag (defaults to true). Using this approach and not setting `knoxsso.cookie.secure.only` in our OOTB `knoxsso.xml` makes it easier to access the admin UI without the need to edit the `knoxsso` topology in case SSL is disabled.
## How was this patch tested?
Adding new JUnit tests:
```
$ mvn clean -Dshellcheck=true -T1C verify -Prelease,package
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:33 min (Wall Clock)
[INFO] Finished at: 2019-08-25T17:21:54+02:00
[INFO] Final Memory: 384M/2246M
[INFO] ------------------------------------------------------------------------
```
Also tested the deliverable by changing the values in `gateway-site.xml` and `knoxsso.xml` as follows:
```
ssl.enabled=false
knoxsso.cookie.secure.only is not set
----
ssl.enabled=true
knoxsso.cookie.secure.only is not set
----
ssl.enabled=false
knoxsso.cookie.secure.only=false
----
ssl.enabled=false
knoxsso.cookie.secure.only=true
```
It's been working as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services