[GitHub] [kafka] LiamClarkeNZ commented on issue #8520: Add explicit grace period to tumbling window example

[GitBox <gi...@apache.org>]

LiamClarkeNZ commented on issue #8520:
URL: https://github.com/apache/kafka/pull/8520#issuecomment-616842780


   Yep, fine by me. :)
   
   On Tue, Apr 21, 2020 at 9:32 AM John Roesler <no...@github.com>
   wrote:
   
   > *@vvcephei* commented on this pull request.
   >
   > Hey @LiamClarkeNZ <https://github.com/LiamClarkeNZ> , thanks for the docs
   > improvement! Everything looks good to me, except I'd request we remove
   > L3267. What do you think?
   > ------------------------------
   >
   > In docs/streams/developer-guide/dsl-api.html
   > <https://github.com/apache/kafka/pull/8520#discussion_r411704050>:
   >
   > > @@ -3262,12 +3262,15 @@ <h5><a class="toc-backref" href="#id16">KTable-KTable Foreign-Key
   >  <span class="kn">import</span> <span class="nn">org.apache.kafka.streams.kstream.TimeWindows</span><span class="o">;</span>
   >
   >  <span class="c1">// A tumbling time window with a size of 5 minutes (and, by definition, an implicit</span>
   > -<span class="c1">// advance interval of 5 minutes).</span>
   > +<span class="c1">// advance interval of 5 minutes). Note the explicit grace period, as the current</span>
   > +<span class="c1">// default value is 24 hours, which may be larger than needed for smaller windows. </span>
   > +<span class="c1">// Note that this default may change in future major version releases.</span>
   >
   > I'd remove the note about changing the default out. We can either find a
   > non-breaking way to change defaults (see
   > https://issues.apache.org/jira/browse/KAFKA-8924?focusedCommentId=17088091&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17088091
   > ), or we can't change it.
   >
   > I'd rather not make people paranoid that we're going to break their app
   > semantics from underneath them, because we won't.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/kafka/pull/8520#pullrequestreview-396825822>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AC2Q2JBRKYG2DJOHRDBMR63RNS5N7ANCNFSM4MMD4ZYA>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org