Re: Review Request 57580: Enhance Kafka Service Check

[Wang Jie <wa...@cmss.chinamobile.com>]

> On 三月 14, 2017, 9:51 a.m., Dmitro Lisnichenko wrote:
> > Ship It!

Thank you so much for reviewing my patch on reviewboard, and could you commit the patch ? Thanks


- Wang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57580/#review168877
-----------------------------------------------------------


On 三月 14, 2017, 1:23 a.m., Wang Jie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57580/
> -----------------------------------------------------------
> 
> (Updated 三月 14, 2017, 1:23 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrii Tkach, Dmitro Lisnichenko, Jaimin Jetly, Jayush Luniya, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-20434
>     https://issues.apache.org/jira/browse/AMBARI-20434
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Problem:
> Kafka Service Check  will create the kafka topic only if the topic doesn't exist.
> if it exists, Kafka Service Check will return success directly.
> After topic is being created, we sense that each time running service check will not reflect the kafka actual state correctly
> 
> Suggestion:
> Every running kafka service check, delete the existed topic and recreate it.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/service_check.py 0f3a417 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/configuration/kafka-broker.xml 0275358 
> 
> 
> Diff: https://reviews.apache.org/r/57580/diff/1/
> 
> 
> Testing
> -------
> 
> Done
> 
> 
> Thanks,
> 
> Wang Jie
> 
>