[GitHub] [airflow] potiuk commented on pull request #28319: Selective checks for API did not match API test specification

[GitBox <gi...@apache.org>]

potiuk commented on PR #28319:
URL: https://github.com/apache/airflow/pull/28319#issuecomment-1347457987

   
   > Looks like the actual command is constructed in another place: https://github.com/apache/airflow/actions/runs/3680179020/jobs/6225576889#step:6:1901
   > 
   > ```
   > Running tests tests/api tests/api_connexion 
   > 
   > 
   > Starting the tests with those pytest arguments: --verbosity=0 --strict-markers --durations=100 --maxfail=50 --color=yes --junitxml=/files/test_result-API-sqlite.xml --timeouts-order moi --setup-timeout=60 --execution-timeout=60 --teardown-timeout=60 --output=/files/warnings-API-sqlite.txt --disable-warnings -rfEX --with-db-init tests/api tests/api_connexion
   > ```
   
   Yep. This is exactly what we are synchronizing with. The test command specifically calls out the directories to use and the regexp in selective checks is used to determine if it should be run or not.
   
   So what the change brings is syncing these two:
   
   1) selective tests determines which file changes should trigger the tests
   2) the command you pointed out executes those
   
   The problem was that the regexp also matched `test_api_internal` because this is how regexp works when there is no '/'. This PR changes the regexp to take into account the fact that there might be other directores starting with `tests_api` - they were previously matched by regexp but not executed by the "API" test type (when you run `pytest tests_api tests_connexion` the `tests_api_internal` are not run.
   
   When this PR is merged, if there is a change coming in `tests_api_internal`, it is treated as `other` which triggers "all" test. Which is what we want.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org