You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "adamreeve (via GitHub)" <gi...@apache.org> on 2025/10/16 03:30:01 UTC
[PR] GH-47830: [Python] Run source and binary RC verification steps in subshells [arrow]
adamreeve opened a new pull request, #47831:
URL: https://github.com/apache/arrow/pull/47831
### Rationale for this change
Isolates environment variable changes made when verifying the source from the tests that verify the binaries, to prevent these causing errors like in #47830.
### What changes are included in this PR?
Changes `verify-release-candidate.sh` to run `test_source_distribution` and `test_binary_distribution` in subshells.
### Are these changes tested?
I've tested this manually, I'm not sure if there are any existing CI tests that run this script on PRs.
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47830: [Release] Run RC verification source testing step in a subshell [arrow]
Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve merged PR #47831:
URL: https://github.com/apache/arrow/pull/47831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47830: [Release] Run RC verification source testing step in a subshell [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #47831:
URL: https://github.com/apache/arrow/pull/47831#issuecomment-3409443904
I don't have a strong opinion for it. We can merge this as-is or wait for comments from others in a few days before we merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47830: [Release] Run source and binary RC verification steps in subshells [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #47831:
URL: https://github.com/apache/arrow/pull/47831#discussion_r2434624733
##########
dev/release/verify-release-candidate.sh:
##########
@@ -1027,8 +1027,10 @@ TEST_SUCCESS=no
setup_tempdir
ensure_source_directory
-test_source_distribution
-test_binary_distribution
+# Run source and binary tests in subshells so environment variables
+# set for source testing aren't exposed to the binary tests.
+(test_source_distribution)
+(test_binary_distribution)
Review Comment:
We don't need this, right?
```suggestion
test_binary_distribution
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47830: [Release] Run RC verification source testing step in a subshell [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #47831:
URL: https://github.com/apache/arrow/pull/47831#issuecomment-3420238940
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f6e48b48cd91a9c5e3242c0ba7b6c93c54658e3d.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/53136054844) has more details. It also includes information about 23 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47830: [Release] Run source and binary RC verification steps in subshells [arrow]
Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on code in PR #47831:
URL: https://github.com/apache/arrow/pull/47831#discussion_r2434728152
##########
dev/release/verify-release-candidate.sh:
##########
@@ -1027,8 +1027,10 @@ TEST_SUCCESS=no
setup_tempdir
ensure_source_directory
-test_source_distribution
-test_binary_distribution
+# Run source and binary tests in subshells so environment variables
+# set for source testing aren't exposed to the binary tests.
+(test_source_distribution)
+(test_binary_distribution)
Review Comment:
No you're right, I guess I did it for consistency. I'll change this back and update the comment too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47830: [Release] Run RC verification source testing step in a subshell [arrow]
Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on PR #47831:
URL: https://github.com/apache/arrow/pull/47831#issuecomment-3409399129
> Or we can restore `DYLD_LIBRARY_PATH`/`LD_LIBRARY_PATH` at the end of `test_source_distribution`.
I prefer the subshell approach so we don't need to worry about which environment variables might have changed, but I'm happy to do it that way if you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47830: [Release] Run RC verification source testing step in a subshell [arrow]
Posted by "adamreeve (via GitHub)" <gi...@apache.org>.
adamreeve commented on PR #47831:
URL: https://github.com/apache/arrow/pull/47831#issuecomment-3409457606
:+1: let's leave this for a few days in case someone else has comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org