You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/18 10:04:32 UTC
[GitHub] [incubator-seatunnel] ic4y opened a new pull request, #2195: [Feature][st-engine] add server in NodeExtension
ic4y opened a new pull request, #2195:
URL: https://github.com/apache/incubator-seatunnel/pull/2195
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #2195: [Feature][st-engine] add server in NodeExtension
Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2195:
URL: https://github.com/apache/incubator-seatunnel/pull/2195#issuecomment-1188840262
> > @CalvinKirs 5.X Hazelcast and JET are under the same module, we don't want to introduce JET. and checked by checkLicense.sh, it is true that only hazelcast-4.2.jar
>
> I don't think this is a good reason, often newer versions get more maintenance, bug fixes, etc. I think we should discuss this.
>
> and any design about this? You submitted a large module without any description.
Ok i upgraded to 5.1，This related design is in #2210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on a diff in pull request #2195: [Feature][st-engine] add server in NodeExtension
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on code in PR #2195:
URL: https://github.com/apache/incubator-seatunnel/pull/2195#discussion_r924179457
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -731,4 +731,5 @@ zookeeper-jute-3.5.9.jar
zstd-jni-1.3.3-1.jar
zstd-jni-1.4.3-1.jar
jakarta.activation-api-1.2.1.jar
-jakarta.xml.bind-api-2.3.2.jar
\ No newline at end of file
+jakarta.xml.bind-api-2.3.2.jar
+hazelcast-4.2.jar
Review Comment:
So please don't make extraneous formatting modifications. even if it's small.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on pull request #2195: [Feature][st-engine] add server in NodeExtension
Posted by GitBox <gi...@apache.org>.
ic4y commented on PR #2195:
URL: https://github.com/apache/incubator-seatunnel/pull/2195#issuecomment-1188714119
@CalvinKirs
5.X Hazelcast and JET are under the same module, we don't want to introduce JET.
and checked by checkLicense.sh, it is true that only hazelcast-4.2.jar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2195: [Feature][st-engine] add server in NodeExtension
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2195:
URL: https://github.com/apache/incubator-seatunnel/pull/2195#issuecomment-1188707415
could you check again? you add the new jar, but the License file only adds one column.
btw, why did we don't use 5.x?
has any issue or design with this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2195: [Feature][st-engine] add server in NodeExtension
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2195:
URL: https://github.com/apache/incubator-seatunnel/pull/2195#issuecomment-1188720831
> @CalvinKirs 5.X Hazelcast and JET are under the same module, we don't want to introduce JET. and checked by checkLicense.sh, it is true that only hazelcast-4.2.jar
I don't think this is a good reason, often newer versions get more maintenance, bug fixes, etc. I think we should discuss this.
and any design about this? You submitted a large module without any description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #2195: [Feature][st-engine] add server in NodeExtension
Posted by GitBox <gi...@apache.org>.
ic4y commented on code in PR #2195:
URL: https://github.com/apache/incubator-seatunnel/pull/2195#discussion_r924281246
##########
tools/dependencies/known-dependencies.txt:
##########
@@ -731,4 +731,5 @@ zookeeper-jute-3.5.9.jar
zstd-jni-1.3.3-1.jar
zstd-jni-1.4.3-1.jar
jakarta.activation-api-1.2.1.jar
-jakarta.xml.bind-api-2.3.2.jar
\ No newline at end of file
+jakarta.xml.bind-api-2.3.2.jar
+hazelcast-4.2.jar
Review Comment:
This is caused by the `\n`. Adding a new line requires a `\n`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2195: [Feature][st-engine] add server in NodeExtension
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2195:
URL: https://github.com/apache/incubator-seatunnel/pull/2195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org