You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mtunique <gi...@git.apache.org> on 2017/04/13 11:23:47 UTC

[GitHub] flink pull request #3718: [FLINK-6112] Support Calcite 1.12's new numerical ...

GitHub user mtunique opened a pull request:

    https://github.com/apache/flink/pull/3718

    [FLINK-6112] Support Calcite 1.12's new numerical functions

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [x] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    Because the function `asin` conflicts with the keyword `as`, I add keyword `ASIN` in `ExpressionParser.scala`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mtunique/flink FLINK-6112

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3718.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3718
    
----
commit 42ddcb3cf59f2c23e12dfb74b6596dd9a19dddb2
Author: mtunique <oa...@gmail.com>
Date:   2017-04-07T10:04:03Z

    add sin function

commit 8c4c08215446264eaa0439a8d771ff895e92943e
Author: mtunique <oa...@gmail.com>
Date:   2017-04-11T14:08:03Z

    add some builtin function

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3718: [FLINK-6112] Support Calcite 1.12's new numerical ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3718


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3718: [FLINK-6112] Support Calcite 1.12's new numerical functio...

Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/3718
  
    Thanks for the PR @mtunique. I quickly looked through the changes, it looks very good. I will review it in the next days, I think we can include it in the 1.3 release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3718: [FLINK-6112] Support Calcite 1.12's new numerical functio...

Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/3718
  
    Merging...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---