You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by "Niklas Therning (JIRA)" <ji...@apache.org> on 2006/04/11 22:16:19 UTC

[jira] Resolved: (DIRMINA-201) Make the CumulativeProtocolDecoder "slice compatible"

     [ http://issues.apache.org/jira/browse/DIRMINA-201?page=all ]
     
Niklas Therning resolved DIRMINA-201:
-------------------------------------

    Fix Version: 0.9.4
     Resolution: Fixed

I've applied the patches and all tests pass. Robert, thanks for your contribution! It would be great if you could have a quick look at the affected files and let me know if there's something wrong. If not, please close this issue.

> Make the CumulativeProtocolDecoder "slice compatible"
> -----------------------------------------------------
>
>          Key: DIRMINA-201
>          URL: http://issues.apache.org/jira/browse/DIRMINA-201
>      Project: Directory MINA
>         Type: Improvement

>     Versions: 0.9.3
>     Reporter: Robert Greig
>     Assignee: Niklas Therning
>      Fix For: 0.9.4
>  Attachments: CumulativeProtocolDecoder.java, CumulativeProtocolDecoder.java, CumulativeProtocolDecoder.java.diff, SocketIoProcessor.java, SocketIoProcessor.java.diff
>
> There is a problem with using slice() along with the CumulativeProtocolDecoder. 
> The problem is that the CPD does a compact() when it has completed the attempt to decode the buffer, and then reuses the buffer.
> If your decoder expects to be able to take a slice() of the buffer and use that it will find the data gets corrupted by the next call to the CumulativeProtocolDecoder.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira