You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by rushikesavareddy <gi...@git.apache.org> on 2017/05/31 08:46:41 UTC
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
GitHub user rushikesavareddy opened a pull request:
https://github.com/apache/eagle/pull/941
[EAGLE-968] Fix for email issue in 0.5 eagle version
<!--
{% comment %}
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to you under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
{% endcomment %}
-->
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[EAGLE-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rushikesavareddy/eagle branch-0.5
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/941.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #941
----
commit 215329d7fb13e1e5576b18ad09c0b23e698e14a9
Author: kreddylh <kr...@paypal.com>
Date: 2017-05-31T08:43:09Z
Fix for email issue in 0.5 eagle version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #941: [EAGLE-968] Fix for email issue in 0.5 eagle version
Posted by coheigea <gi...@git.apache.org>.
Github user coheigea commented on the issue:
https://github.com/apache/eagle/pull/941
I tested this by removing the extraneous commits (see https://issues.apache.org/jira/secure/attachment/12908828/941.patch) and it works fine.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r119933968
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -25,7 +25,7 @@
import org.apache.velocity.runtime.resource.loader.ClasspathResourceLoader;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-
--- End diff --
remove this line
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r120471741
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -54,23 +54,24 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
+ velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
velocityEngine.init();
config.put("mail.transport.protocol", "smtp");
if (Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
session = Session.getInstance(config, new Authenticator() {
protected PasswordAuthentication getPasswordAuthentication() {
return new PasswordAuthentication(
- config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
- config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
- );
+ config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
--- End diff --
pls remove this alignment change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by rushikesavareddy <gi...@git.apache.org>.
Github user rushikesavareddy commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r120271781
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
--- End diff --
@jhsenjaliya incorporated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by asdf2014 <gi...@git.apache.org>.
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r119341799
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
--- End diff --
I think it would be better to put the fully qualified name in the `import` snippet. In addition, here is a problem that `EagleMailClient` need be refactoring for sloving code duplication, so, in addition to` alert-engine` module, there `eagle-common` module is also need to be modified.
```java
import org.apache.velocity.runtime.log.NullLogChute;
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #941: [EAGLE-968] Fix for email issue in 0.5 eagle version
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/941
@rushikesavareddy , there are issues with this PR, please check, there should be only related changes here, this looks like is picking other changes as well that are not yours.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by rushikesavareddy <gi...@git.apache.org>.
Github user rushikesavareddy commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r121674210
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -54,23 +54,24 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
+ velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
velocityEngine.init();
config.put("mail.transport.protocol", "smtp");
if (Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
session = Session.getInstance(config, new Authenticator() {
protected PasswordAuthentication getPasswordAuthentication() {
return new PasswordAuthentication(
- config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
- config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
- );
+ config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
+ config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
+ );
}
});
} else {
session = Session.getInstance(config, new Authenticator() {
});
}
-
--- End diff --
@jhsenjaliya fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #941: [EAGLE-968] Fix for email issue in 0.5 eagle version
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/941
Thanks @rushikesavareddy for the PR and @coheigea for verifying. merging it now.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r120473184
--- Diff: eagle-core/eagle-common/src/main/java/org/apache/eagle/common/mail/EagleMailClient.java ---
@@ -53,16 +53,18 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS, Log4JLogChute.class.getName());
--- End diff --
same comment as above, to use full class name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #941: [EAGLE-968] Fix for email issue in 0.5 eagle version
Posted by rushikesavareddy <gi...@git.apache.org>.
Github user rushikesavareddy commented on the issue:
https://github.com/apache/eagle/pull/941
@jhsenjaliya
build was successful with checkStyleFlag enabled. Changed base/target branch to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/eagle/pull/941
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by rushikesavareddy <gi...@git.apache.org>.
Github user rushikesavareddy commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r121674160
--- Diff: eagle-core/eagle-common/src/main/java/org/apache/eagle/common/mail/EagleMailClient.java ---
@@ -53,16 +53,18 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS, Log4JLogChute.class.getName());
+ velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
velocityEngine.init();
config.put("mail.transport.protocol", "smtp");
if (Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
session = Session.getInstance(config, new Authenticator() {
protected PasswordAuthentication getPasswordAuthentication() {
return new PasswordAuthentication(
- config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
- config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
- );
+ config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
--- End diff --
@jhsenjaliya fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by rushikesavareddy <gi...@git.apache.org>.
Github user rushikesavareddy commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r121674184
--- Diff: eagle-core/eagle-common/src/main/java/org/apache/eagle/common/mail/EagleMailClient.java ---
@@ -53,16 +53,18 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS, Log4JLogChute.class.getName());
--- End diff --
@jhsenjaliya fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r120471811
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -54,23 +54,24 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
+ velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
velocityEngine.init();
config.put("mail.transport.protocol", "smtp");
if (Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
session = Session.getInstance(config, new Authenticator() {
protected PasswordAuthentication getPasswordAuthentication() {
return new PasswordAuthentication(
- config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
- config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
- );
+ config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
+ config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
+ );
}
});
} else {
session = Session.getInstance(config, new Authenticator() {
});
}
-
--- End diff --
pls remove this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r119933990
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
--- End diff --
alignment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r120473246
--- Diff: eagle-core/eagle-common/src/main/java/org/apache/eagle/common/mail/EagleMailClient.java ---
@@ -53,16 +53,18 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS, Log4JLogChute.class.getName());
+ velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
velocityEngine.init();
config.put("mail.transport.protocol", "smtp");
if (Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
session = Session.getInstance(config, new Authenticator() {
protected PasswordAuthentication getPasswordAuthentication() {
return new PasswordAuthentication(
- config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
- config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
- );
+ config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
--- End diff --
pls fix this misalignment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #941: [EAGLE-968] Fix for email issue in 0.5 eagle version
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/941
@rushikesavareddy , can u pls rebase this from master, i think that will resolve the issue of having other non-relevant commits, pls also take care of code formatting.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r119687625
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -54,6 +54,8 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,org.apache.velocity.runtime.log.NullLogChute.class.getName());
--- End diff --
I believe, right way to fix this would be
```
velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS, org.apache.velocity.runtime.log.Log4JLogChute.class.getName());
velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by rushikesavareddy <gi...@git.apache.org>.
Github user rushikesavareddy commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r120271788
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -25,7 +25,7 @@
import org.apache.velocity.runtime.resource.loader.ClasspathResourceLoader;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-
--- End diff --
@jhsenjaliya done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #941: [EAGLE-968] Fix for email issue in 0.5 eagle version
Posted by jhsenjaliya <gi...@git.apache.org>.
Github user jhsenjaliya commented on the issue:
https://github.com/apache/eagle/pull/941
@rushikesavareddy pls make sure this PR passes with checkStyle flag ON.
Also you can make the target branch to master to trigger the CI check and I will pick it for branch-0.5. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #941: [EAGLE-968] Fix for email issue in 0.5 eagle versio...
Posted by rushikesavareddy <gi...@git.apache.org>.
Github user rushikesavareddy commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r121674223
--- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java ---
@@ -54,23 +54,24 @@ public EagleMailClient(final Properties config) {
velocityEngine = new VelocityEngine();
velocityEngine.setProperty(RuntimeConstants.RESOURCE_LOADER, "classpath");
velocityEngine.setProperty("classpath.resource.loader.class", ClasspathResourceLoader.class.getName());
+ velocityEngine.setProperty(RuntimeConstants.RUNTIME_LOG_LOGSYSTEM_CLASS,Log4JLogChute.class.getName());
+ velocityEngine.setProperty("runtime.log.logsystem.log4j.logger", LOG.getName());
velocityEngine.init();
config.put("mail.transport.protocol", "smtp");
if (Boolean.parseBoolean(config.getProperty(AlertEmailConstants.CONF_MAIL_AUTH))) {
session = Session.getInstance(config, new Authenticator() {
protected PasswordAuthentication getPasswordAuthentication() {
return new PasswordAuthentication(
- config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
- config.getProperty(AlertEmailConstants.CONF_AUTH_PASSWORD)
- );
+ config.getProperty(AlertEmailConstants.CONF_AUTH_USER),
--- End diff --
@jhsenjaliya fixed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---