You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sergeyshevch (via GitHub)" <gi...@apache.org> on 2023/01/23 13:01:35 UTC
[GitHub] [superset] sergeyshevch opened a new pull request, #22827: feat(helm): Add ability to customize affinity per deployment
sergeyshevch opened a new pull request, #22827:
URL: https://github.com/apache/superset/pull/22827
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Added ability to add affinity per deployment
Added ability to add topologySpreadConstraints https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Specify supersetNode.affinity
- Affinity should be added to helm template result
- Specify global affinity
- Both affinity should be added to helm template result
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ x ] Has associated issue: https://github.com/apache/superset/issues/19250
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sergeyshevch commented on pull request #22827: feat(helm): Add ability to customize affinity per deployment
Posted by "sergeyshevch (via GitHub)" <gi...@apache.org>.
sergeyshevch commented on PR #22827:
URL: https://github.com/apache/superset/pull/22827#issuecomment-1431330543
@a-poluyanov You also need to add label selectors
Example:
```
topologySpreadConstraints:
- maxSkew: 1
whenUnsatisfiable: DoNotSchedule
topologyKey: kubernetes.io/hostname
labelSelector:
matchLabels:
app: superset
```
Selectors are quite different across deployments
```
app: superset
app: superset-worker
etc
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #22827: feat(helm): Add ability to customize affinity per deployment
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #22827:
URL: https://github.com/apache/superset/pull/22827#issuecomment-1400722911
Please bump the version in `Chart.yaml` and re-gen the README using `helm-docs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] a-poluyanov commented on pull request #22827: feat(helm): Add ability to customize affinity per deployment
Posted by "a-poluyanov (via GitHub)" <gi...@apache.org>.
a-poluyanov commented on PR #22827:
URL: https://github.com/apache/superset/pull/22827#issuecomment-1431325725
Hello, I want my helm-swapped superset to be evenly distributed among the nodes of my cluster and I write like this:
```
# -- TopologySpreadConstrains to be added to all deployments
topologySpreadConstraints:
- maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: ScheduleAnyway
```
But the pods are still not evenly distributed, does anyone have an example of how this works?
@sergeyshevch Maybe you have an example of even distribution between nodes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #22827: feat(helm): Add ability to customize affinity per deployment
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #22827:
URL: https://github.com/apache/superset/pull/22827
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sergeyshevch commented on pull request #22827: feat(helm): Add ability to customize affinity per deployment
Posted by "sergeyshevch (via GitHub)" <gi...@apache.org>.
sergeyshevch commented on PR #22827:
URL: https://github.com/apache/superset/pull/22827#issuecomment-1400748577
@craig-rueda Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org