You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/08/23 15:29:38 UTC
[GitHub] [incubator-opendal] tisonkun opened a new pull request, #2918: fix(binding/java): Overwrite default NOTICE file with correct years
tisonkun opened a new pull request, #2918:
URL: https://github.com/apache/incubator-opendal/pull/2918
This closes https://github.com/apache/incubator-opendal/issues/2916.
Verified locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on pull request #2918: fix(binding/java): Overwrite default NOTICE file with correct years
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #2918:
URL: https://github.com/apache/incubator-opendal/pull/2918#issuecomment-1690865614
@raboof Thanks for your information!
I added this NOTICE file following Flink's practice. Correct years is one of the target, the other one is properly mentioning dependencies' NOTICE/LICENSE if any, although opendal-java doesn't have one now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] tisonkun commented on pull request #2918: fix(binding/java): Overwrite default NOTICE file with correct years
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on PR #2918:
URL: https://github.com/apache/incubator-opendal/pull/2918#issuecomment-1690866514
But the timezone problem seems need to resolve as for "[project.build.outputTimestamp](https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-do-i-configure-my-maven-build)". Do you have some idea here or may you directly send a patch against this repo to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] raboof commented on pull request #2918: fix(binding/java): Overwrite default NOTICE file with correct years
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #2918:
URL: https://github.com/apache/incubator-opendal/pull/2918#issuecomment-1691146684
> I added this NOTICE file following Flink's practice. Correct years is one of the target, the other one is properly mentioning dependencies' NOTICE/LICENSE if any, although opendal-java doesn't have one now.
:+1: great!
> But the timezone problem seems need to resolve as for "[project.build.outputTimestamp](https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-do-i-configure-my-maven-build)". Do you have some idea here or may you directly send a patch against this repo to fix it?
I don't think there is any timezone issue anymore now that you've replaced the NOTICE. The code in https://github.com/apache/maven-remote-resources-plugin that introduced that problem is not used in the opendal binding project anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] raboof commented on pull request #2918: fix(binding/java): Overwrite default NOTICE file with correct years
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #2918:
URL: https://github.com/apache/incubator-opendal/pull/2918#issuecomment-1690472077
This is indeed a reasonable way to make sure the NOTICE contains correct years. For example, commons-collections [does something similar](https://github.com/apache/commons-collections/blob/master/NOTICE.txt).
An alternative approach is to make sure [`inceptionYear`](https://maven.apache.org/pom.html#More_Project_Information) and [`project.build.outputTimestamp`](https://maven.apache.org/guides/mini/guide-reproducible-builds.html#how-do-i-configure-my-maven-build) are set to a 'realistic' values before starting the release process. For example maven-remote-resources-plugin [does this](https://github.com/apache/maven-remote-resources-plugin/commit/2fb369bc7c29e219683e1b0a72e0ca9e75b09d1c#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R71) (automatically via maven-release-plugin, even - but you might not be using that).
The latter approach still has the timezone problem mentioned earlier - though it is much less likely to be encountered for 'realistic' dates. https://github.com/apache/maven-remote-resources-plugin/pull/39 should fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2918: fix(binding/java): Overwrite default NOTICE file with correct years
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2918:
URL: https://github.com/apache/incubator-opendal/pull/2918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org