[GitHub] [arrow] amoeba commented on a diff in pull request #14455: MINOR: [R] [Docs] Fix link in ?cast documentation

[GitBox <gi...@apache.org>]

amoeba commented on code in PR #14455:
URL: https://github.com/apache/arrow/pull/14455#discussion_r999875693


##########
r/R/dplyr-funcs-type.R:
##########
@@ -43,7 +43,7 @@ register_bindings_type <- function() {
 #'   mutate(cyl = cast(cyl, string()))
 #' }
 #' @keywords internal
-#' @seealso https://arrow.apache.org/docs/cpp/api/compute.html for the list of
+#' @seealso [Arrow C++ documentation](https://arrow.apache.org/docs/cpp/compute.html) for the list of

Review Comment:
   Changing the link was actually a mistake on my part and I think linking to the cast options in the API docs makes the most sense. Not sure on which link is more stable but I'll note that https://arrow.apache.org/docs/cpp/api/compute.html?highlight=castoptions#arrow%3A%3Acompute%3A%3ACastOptions also works and is maybe preferable?
   
   Re:
   
   > - manually describe the options here, and update them if new options are implemented - perhaps the API is stable enough now that this is unlikely
   
   At first glance, I wonder if this is too much detail. Do users tend to use CastOptions much from R or do we expect them to? Maybe a separate page would be better or we could add more info to `?cast_options`? I could go either way (just link to the C++ docs from ?cast versus fill this in more, as you suggest).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org