You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "BewareMyPower (via GitHub)" <gi...@apache.org> on 2023/06/16 08:53:02 UTC

[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #20591: [fix] [client] Messages lost when consumer reconnect

BewareMyPower commented on code in PR #20591:
URL: https://github.com/apache/pulsar/pull/20591#discussion_r1231976122


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -136,6 +136,7 @@
 
     protected volatile MessageId lastDequeuedMessageId = MessageId.earliest;
     private volatile MessageId lastMessageIdInBroker = MessageId.earliest;
+    protected volatile CompletableFuture<Void> inProgressSubscribeFuture;

Review Comment:
   I think it would be better to move this logic to `ConnectionHandler`. We should not protect `connectionOpen`, instead, we should protect `grabCnx`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org