You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/13 13:41:01 UTC
[GitHub] [camel-website] zregvart commented on a change in pull request
#210: Feature Avatar on Blog Posts
zregvart commented on a change in pull request #210: Feature Avatar on Blog Posts
URL: https://github.com/apache/camel-website/pull/210#discussion_r392233292
##########
File path: layouts/blog/post.html
##########
@@ -9,8 +9,15 @@ <h1><a href="{{.Page.Permalink}}">{{ .Title }}</a></h1>
<div class="post">
<aside>
<div class="summary">{{ .Params.preview }}</div>
- <time itemprop="published" datetime="{{ dateFormat "2006-01-02" .PublishDate }}" title="{{ dateFormat "Monday, January 2, 2006" .PublishDate }}">{{ dateFormat "January 2, 2006" .PublishDate }}</time>
- <p>by <span rel="author">{{ .Params.author }}</span></p>
+ <table>
+ <tr>
+ <td rowspan="2"> <img src="https://www.w3schools.com/howto/img_avatar.png" alt="Avatar" class="avatar"> </td>
+ <td><p>by <span rel="author">{{ .Params.author }}</span></p></td>
+ </tr>
+ <tr id = "publishDate">
+ <td><time itemprop="published" datetime="{{ dateFormat "2006-01-02" .PublishDate }}" title="{{ dateFormat "Monday, January 2, 2006" .PublishDate }}">{{ dateFormat "January 2, 2006" .PublishDate }}</time></td>
+ </tr>
+ </table>
Review comment:
We try to use semantic HTML, introducing tables for this is not the right approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services