You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/11 06:02:57 UTC
[GitHub] [spark] LuciferYang edited a comment on pull request #35477: [SPARK-38175][SQL] Clean up unused parameters of `castDecimalToIntegralTypeCode` in `Cast.scala`
LuciferYang edited a comment on pull request #35477:
URL: https://github.com/apache/spark/pull/35477#issuecomment-1035906671
My idea is to add the `- wunused: params` option for compilation, then analyze the compilation log to find `unused parameters in private methods` in Spark code and fix them, It will take some time to complete the work because the compilation log also includes `unused parameters in non private methods` @srowen @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org