You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@isis.apache.org by GitBox <gi...@apache.org> on 2021/02/28 15:28:08 UTC
[GitHub] [isis-app-simpleapp] mwhesse opened a new pull request #4: JDO simplification
mwhesse opened a new pull request #4:
URL: https://github.com/apache/isis-app-simpleapp/pull/4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [isis-app-simpleapp] danhaywood commented on a change in pull request #4: JDO simplification
Posted by GitBox <gi...@apache.org>.
danhaywood commented on a change in pull request #4:
URL: https://github.com/apache/isis-app-simpleapp/pull/4#discussion_r584323845
##########
File path: module-simple/src/main/java/domainapp/modules/simple/dom/so/SimpleObject.java
##########
@@ -20,23 +23,32 @@
import static org.apache.isis.applib.annotation.SemanticsOf.IDEMPOTENT;
import static org.apache.isis.applib.annotation.SemanticsOf.NON_IDEMPOTENT_ARE_YOU_SURE;
-import domainapp.modules.simple.SimpleModule;
+import domainapp.modules.simple.dom.so.co.ChildObject;
import domainapp.modules.simple.types.Name;
import domainapp.modules.simple.types.Notes;
import lombok.Getter;
import lombok.Setter;
-import lombok.ToString;
import lombok.val;
@javax.jdo.annotations.PersistenceCapable(identityType=IdentityType.DATASTORE, schema = "simple")
@javax.jdo.annotations.DatastoreIdentity(strategy=IdGeneratorStrategy.IDENTITY, column="id")
@javax.jdo.annotations.Version(strategy= VersionStrategy.DATE_TIME, column="version")
@javax.jdo.annotations.Unique(name="SimpleObject_name_UNQ", members = {"name"})
+@javax.jdo.annotations.Queries({
+ @javax.jdo.annotations.Query(name = "findByName",
+ value = "SELECT FROM domainapp.modules.simple.dom.so.SimpleObject WHERE "
Review comment:
consistent formatting with query below
##########
File path: module-simple/src/main/java/domainapp/modules/simple/dom/so/SimpleObject.java
##########
@@ -45,49 +57,164 @@ public static SimpleObject withName(String name) {
return simpleObject;
}
- public static class ActionDomainEvent extends SimpleModule.ActionDomainEvent<SimpleObject> {}
-
+ /*
+ * These dependencies are automatically injected
+ * into an entity when persisting it or retrieving
+ * it from the persistence layer.
+ */
@Inject RepositoryService repositoryService;
@Inject TitleService titleService;
- @Inject MessageService messageService;
-
+ @Inject MessageService messageService;
+
private SimpleObject() {
}
+ /*
+ * This method is part of the programming model of Apache Isis.
Review comment:
I would have the first sentence describe what the method does.
Then <p> and start a new paragraph, where you can describe the programming model stuff. And a <p> for each subsequent paragraph.
##########
File path: module-simple/src/main/java/domainapp/modules/simple/dom/so/SimpleObject.java
##########
@@ -45,49 +57,164 @@ public static SimpleObject withName(String name) {
return simpleObject;
}
- public static class ActionDomainEvent extends SimpleModule.ActionDomainEvent<SimpleObject> {}
-
+ /*
+ * These dependencies are automatically injected
+ * into an entity when persisting it or retrieving
+ * it from the persistence layer.
+ */
@Inject RepositoryService repositoryService;
@Inject TitleService titleService;
- @Inject MessageService messageService;
-
+ @Inject MessageService messageService;
+
private SimpleObject() {
}
+ /*
+ * This method is part of the programming model of Apache Isis.
+ * The string returned by this method is shown as title on the
+ * default page displaying this entity.
+ *
+ * The location of the entity title on the page can be changed
+ * by moving the "domainObject" element in the layout.xml file
+ * to another location in the grid.
+ */
public String title() {
return "Object: " + getName();
}
-
+
+ /****
Review comment:
don't really like these comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org