You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by Joe Bohn <jo...@gmail.com> on 2010/04/12 22:29:29 UTC
Re: svn commit: r932645 - /incubator/aries/trunk/samples/ariestrader/pom.xml
Jeremy,
Do you recall why these additions were necessary - what type of error
you hit without them?
Joe
On 4/9/10 7:14 PM, hughesj@apache.org wrote:
> Author: hughesj
> Date: Fri Apr 9 23:14:51 2010
> New Revision: 932645
>
> URL: http://svn.apache.org/viewvc?rev=932645&view=rev
> Log:
> ARIES-173 added dependency elements
>
> Modified:
> incubator/aries/trunk/samples/ariestrader/pom.xml
>
> Modified: incubator/aries/trunk/samples/ariestrader/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/pom.xml?rev=932645&r1=932644&r2=932645&view=diff
> ==============================================================================
> --- incubator/aries/trunk/samples/ariestrader/pom.xml (original)
> +++ incubator/aries/trunk/samples/ariestrader/pom.xml Fri Apr 9 23:14:51 2010
> @@ -36,6 +36,20 @@
> <siteId>ariestrader</siteId>
> </properties>
>
> +<dependencyManagement>
> +<dependencies>
> +<dependency>
> +<groupId>org.apache.aries.samples.ariestrader</groupId>
> +<artifactId>modules</artifactId>
> +<version>${version}</version>
> +</dependency>
> +<dependency>
> +<groupId>org.apache.aries.samples.ariestrader</groupId>
> +<artifactId>assemblies</artifactId>
> +<version>${version}</version>
> +</dependency>
> +</dependencies>
> +</dependencyManagement>
>
> <modules>
> <!-- application components-->
>
>
>
--
Joe
Re: svn commit: r932645 - /incubator/aries/trunk/samples/ariestrader/pom.xml
Posted by Jeremy Hughes <hu...@apache.org>.
I've re-read David's post and some things don't make sense. This might
be easier to chat about on IRC and post the results back here
afterwards.
Cheers,
Jeremy
On 14 April 2010 02:46, Joe Bohn <jo...@gmail.com> wrote:
> Sorry, I should have been more clear on the cause of my confusion. I'm
> sure there is a good reason for adding it where you did but I was just
> surprised after reading the reference again.
>
> Based upon the reference from David I would have expected that the
> transaction.blueprint version would have been pulled in from the
> samples/pom.xml dependencyManagement reference to transaction with the scope
> import (4b). If for some reason that didn't work, then I would have
> expected that we would have added the transaction.blueprint version into
> some other dependencyManagement section in one of the parent poms -
> preferably samples/pom.xml (4a). I was confused to see the version added
> directly to the dependency itself which seems to conflict with 5.
>
> Joe
>
>
>
> On 4/13/10 5:07 PM, Jeremy Hughes wrote:
>>
>> :-) This is the text from that commit:
>>
>> Modified:
>> incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml?rev=932648&r1=932647&r2=932648&view=diff
>>
>> ==============================================================================
>> ---
>> incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
>> (original)
>> +++
>> incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
>> Fri Apr 9 23:42:04 2010
>> @@ -39,6 +39,7 @@
>> <dependency>
>> <groupId>org.apache.aries.transaction</groupId>
>>
>> <artifactId>org.apache.aries.transaction.blueprint</artifactId>
>> +<version>${ariesTransactionVersion}</version>
>> </dependency>
>> <dependency>
>> <groupId>org.apache.geronimo.components</groupId>
>>
>> The version I added in was the version of the transaction module which
>> is outside the samples top level project. AIUI the purpose of the
>> <dependency> mechanism in the pom I referred to below is to avoid
>> having to specify the<version> element of the artifact being defined
>> in the pom. The version of the transaction module is on a
>> (potentially) separate release schedule.
>>
>> Jeremy
>>
>> On 13 April 2010 19:05, Joe Bohn<jo...@gmail.com> wrote:
>>>
>>> Thanks for the reference. This makes sense. However, this makes the
>>> other
>>> change you made right after this (r932648) all the more confusing.
>>>
>>> Joe
>>>
>>> On 4/13/10 12:50 PM, Jeremy Hughes wrote:
>>>>
>>>> On 12 April 2010 21:29, Joe Bohn<jo...@gmail.com> wrote:
>>>>>
>>>>> Jeremy,
>>>>>
>>>>> Do you recall why these additions were necessary - what type of error
>>>>> you
>>>>> hit without them?
>>>>
>>>>> From an email sent by David Jencks on Mar 2 [1]:
>>>>
>>>> 4. each subproject has dependency management for everything included
>>>> in it. In addition, it has its subprojects listed in dependency
>>>> management. (this is bent slightly for the samples). This means that
>>>> (a) modules in a subproject don't need to include versions for use of
>>>> other modules
>>>> (b) you can get dependency management for all the modules in a
>>>> subproject by depending on the subproject pom with scope import. (see
>>>> the samples pom for an example).
>>>>
>>>> 5. As a result of (4), modules don't have any versions in any
>>>> dependency elements.
>>>>
>>>> So I made this change to get the above behaviour. I don't recall the
>>>> error as I had many of them throughout the whirlwind that was the
>>>> release preparation. :-)
>>>>
>>>> [1]
>>>>
>>>> http://mail-archives.apache.org/mod_mbox/incubator-aries-dev/201003.mbox/%3C595020BE-A779-409C-A7F5-AE695731F2C0@yahoo.com%3E
>>>>>
>>>>> Joe
>>>>>
>>>>> On 4/9/10 7:14 PM, hughesj@apache.org wrote:
>>>>>>
>>>>>> Author: hughesj
>>>>>> Date: Fri Apr 9 23:14:51 2010
>>>>>> New Revision: 932645
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=932645&view=rev
>>>>>> Log:
>>>>>> ARIES-173 added dependency elements
>>>>>>
>>>>>> Modified:
>>>>>> incubator/aries/trunk/samples/ariestrader/pom.xml
>>>>>>
>>>>>> Modified: incubator/aries/trunk/samples/ariestrader/pom.xml
>>>>>> URL:
>>>>>>
>>>>>>
>>>>>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/pom.xml?rev=932645&r1=932644&r2=932645&view=diff
>>>>>>
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>> --- incubator/aries/trunk/samples/ariestrader/pom.xml (original)
>>>>>> +++ incubator/aries/trunk/samples/ariestrader/pom.xml Fri Apr 9
>>>>>> 23:14:51
>>>>>> 2010
>>>>>> @@ -36,6 +36,20 @@
>>>>>> <siteId>ariestrader</siteId>
>>>>>> </properties>
>>>>>>
>>>>>> +<dependencyManagement>
>>>>>> +<dependencies>
>>>>>> +<dependency>
>>>>>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>>>>>> +<artifactId>modules</artifactId>
>>>>>> +<version>${version}</version>
>>>>>> +</dependency>
>>>>>> +<dependency>
>>>>>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>>>>>> +<artifactId>assemblies</artifactId>
>>>>>> +<version>${version}</version>
>>>>>> +</dependency>
>>>>>> +</dependencies>
>>>>>> +</dependencyManagement>
>>>>>>
>>>>>> <modules>
>>>>>> <!-- application components-->
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Joe
>>>>>
>>>>
>>>
>>>
>>> --
>>> Joe
>>>
>>
>
>
> --
> Joe
>
Re: svn commit: r932645 - /incubator/aries/trunk/samples/ariestrader/pom.xml
Posted by Joe Bohn <jo...@gmail.com>.
Sorry, I should have been more clear on the cause of my confusion. I'm
sure there is a good reason for adding it where you did but I was just
surprised after reading the reference again.
Based upon the reference from David I would have expected that the
transaction.blueprint version would have been pulled in from the
samples/pom.xml dependencyManagement reference to transaction with the
scope import (4b). If for some reason that didn't work, then I would
have expected that we would have added the transaction.blueprint version
into some other dependencyManagement section in one of the parent poms -
preferably samples/pom.xml (4a). I was confused to see the version
added directly to the dependency itself which seems to conflict with 5.
Joe
On 4/13/10 5:07 PM, Jeremy Hughes wrote:
> :-) This is the text from that commit:
>
> Modified: incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml?rev=932648&r1=932647&r2=932648&view=diff
> ==============================================================================
> --- incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
> (original)
> +++ incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
> Fri Apr 9 23:42:04 2010
> @@ -39,6 +39,7 @@
> <dependency>
> <groupId>org.apache.aries.transaction</groupId>
> <artifactId>org.apache.aries.transaction.blueprint</artifactId>
> +<version>${ariesTransactionVersion}</version>
> </dependency>
> <dependency>
> <groupId>org.apache.geronimo.components</groupId>
>
> The version I added in was the version of the transaction module which
> is outside the samples top level project. AIUI the purpose of the
> <dependency> mechanism in the pom I referred to below is to avoid
> having to specify the<version> element of the artifact being defined
> in the pom. The version of the transaction module is on a
> (potentially) separate release schedule.
>
> Jeremy
>
> On 13 April 2010 19:05, Joe Bohn<jo...@gmail.com> wrote:
>> Thanks for the reference. This makes sense. However, this makes the other
>> change you made right after this (r932648) all the more confusing.
>>
>> Joe
>>
>> On 4/13/10 12:50 PM, Jeremy Hughes wrote:
>>>
>>> On 12 April 2010 21:29, Joe Bohn<jo...@gmail.com> wrote:
>>>>
>>>> Jeremy,
>>>>
>>>> Do you recall why these additions were necessary - what type of error you
>>>> hit without them?
>>>
>>>> From an email sent by David Jencks on Mar 2 [1]:
>>>
>>> 4. each subproject has dependency management for everything included
>>> in it. In addition, it has its subprojects listed in dependency
>>> management. (this is bent slightly for the samples). This means that
>>> (a) modules in a subproject don't need to include versions for use of
>>> other modules
>>> (b) you can get dependency management for all the modules in a
>>> subproject by depending on the subproject pom with scope import. (see
>>> the samples pom for an example).
>>>
>>> 5. As a result of (4), modules don't have any versions in any
>>> dependency elements.
>>>
>>> So I made this change to get the above behaviour. I don't recall the
>>> error as I had many of them throughout the whirlwind that was the
>>> release preparation. :-)
>>>
>>> [1]
>>> http://mail-archives.apache.org/mod_mbox/incubator-aries-dev/201003.mbox/%3C595020BE-A779-409C-A7F5-AE695731F2C0@yahoo.com%3E
>>>>
>>>> Joe
>>>>
>>>> On 4/9/10 7:14 PM, hughesj@apache.org wrote:
>>>>>
>>>>> Author: hughesj
>>>>> Date: Fri Apr 9 23:14:51 2010
>>>>> New Revision: 932645
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=932645&view=rev
>>>>> Log:
>>>>> ARIES-173 added dependency elements
>>>>>
>>>>> Modified:
>>>>> incubator/aries/trunk/samples/ariestrader/pom.xml
>>>>>
>>>>> Modified: incubator/aries/trunk/samples/ariestrader/pom.xml
>>>>> URL:
>>>>>
>>>>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/pom.xml?rev=932645&r1=932644&r2=932645&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>> --- incubator/aries/trunk/samples/ariestrader/pom.xml (original)
>>>>> +++ incubator/aries/trunk/samples/ariestrader/pom.xml Fri Apr 9
>>>>> 23:14:51
>>>>> 2010
>>>>> @@ -36,6 +36,20 @@
>>>>> <siteId>ariestrader</siteId>
>>>>> </properties>
>>>>>
>>>>> +<dependencyManagement>
>>>>> +<dependencies>
>>>>> +<dependency>
>>>>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>>>>> +<artifactId>modules</artifactId>
>>>>> +<version>${version}</version>
>>>>> +</dependency>
>>>>> +<dependency>
>>>>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>>>>> +<artifactId>assemblies</artifactId>
>>>>> +<version>${version}</version>
>>>>> +</dependency>
>>>>> +</dependencies>
>>>>> +</dependencyManagement>
>>>>>
>>>>> <modules>
>>>>> <!-- application components-->
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Joe
>>>>
>>>
>>
>>
>> --
>> Joe
>>
>
--
Joe
Re: svn commit: r932645 - /incubator/aries/trunk/samples/ariestrader/pom.xml
Posted by Jeremy Hughes <hu...@apache.org>.
:-) This is the text from that commit:
Modified: incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
URL: http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml?rev=932648&r1=932647&r2=932648&view=diff
==============================================================================
--- incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
(original)
+++ incubator/aries/trunk/samples/ariestrader/modules/ariestrader-derby-ds/pom.xml
Fri Apr 9 23:42:04 2010
@@ -39,6 +39,7 @@
<dependency>
<groupId>org.apache.aries.transaction</groupId>
<artifactId>org.apache.aries.transaction.blueprint</artifactId>
+ <version>${ariesTransactionVersion}</version>
</dependency>
<dependency>
<groupId>org.apache.geronimo.components</groupId>
The version I added in was the version of the transaction module which
is outside the samples top level project. AIUI the purpose of the
<dependency> mechanism in the pom I referred to below is to avoid
having to specify the <version> element of the artifact being defined
in the pom. The version of the transaction module is on a
(potentially) separate release schedule.
Jeremy
On 13 April 2010 19:05, Joe Bohn <jo...@gmail.com> wrote:
> Thanks for the reference. This makes sense. However, this makes the other
> change you made right after this (r932648) all the more confusing.
>
> Joe
>
> On 4/13/10 12:50 PM, Jeremy Hughes wrote:
>>
>> On 12 April 2010 21:29, Joe Bohn<jo...@gmail.com> wrote:
>>>
>>> Jeremy,
>>>
>>> Do you recall why these additions were necessary - what type of error you
>>> hit without them?
>>
>>> From an email sent by David Jencks on Mar 2 [1]:
>>
>> 4. each subproject has dependency management for everything included
>> in it. In addition, it has its subprojects listed in dependency
>> management. (this is bent slightly for the samples). This means that
>> (a) modules in a subproject don't need to include versions for use of
>> other modules
>> (b) you can get dependency management for all the modules in a
>> subproject by depending on the subproject pom with scope import. (see
>> the samples pom for an example).
>>
>> 5. As a result of (4), modules don't have any versions in any
>> dependency elements.
>>
>> So I made this change to get the above behaviour. I don't recall the
>> error as I had many of them throughout the whirlwind that was the
>> release preparation. :-)
>>
>> [1]
>> http://mail-archives.apache.org/mod_mbox/incubator-aries-dev/201003.mbox/%3C595020BE-A779-409C-A7F5-AE695731F2C0@yahoo.com%3E
>>>
>>> Joe
>>>
>>> On 4/9/10 7:14 PM, hughesj@apache.org wrote:
>>>>
>>>> Author: hughesj
>>>> Date: Fri Apr 9 23:14:51 2010
>>>> New Revision: 932645
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=932645&view=rev
>>>> Log:
>>>> ARIES-173 added dependency elements
>>>>
>>>> Modified:
>>>> incubator/aries/trunk/samples/ariestrader/pom.xml
>>>>
>>>> Modified: incubator/aries/trunk/samples/ariestrader/pom.xml
>>>> URL:
>>>>
>>>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/pom.xml?rev=932645&r1=932644&r2=932645&view=diff
>>>>
>>>>
>>>> ==============================================================================
>>>> --- incubator/aries/trunk/samples/ariestrader/pom.xml (original)
>>>> +++ incubator/aries/trunk/samples/ariestrader/pom.xml Fri Apr 9
>>>> 23:14:51
>>>> 2010
>>>> @@ -36,6 +36,20 @@
>>>> <siteId>ariestrader</siteId>
>>>> </properties>
>>>>
>>>> +<dependencyManagement>
>>>> +<dependencies>
>>>> +<dependency>
>>>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>>>> +<artifactId>modules</artifactId>
>>>> +<version>${version}</version>
>>>> +</dependency>
>>>> +<dependency>
>>>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>>>> +<artifactId>assemblies</artifactId>
>>>> +<version>${version}</version>
>>>> +</dependency>
>>>> +</dependencies>
>>>> +</dependencyManagement>
>>>>
>>>> <modules>
>>>> <!-- application components-->
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Joe
>>>
>>
>
>
> --
> Joe
>
Re: svn commit: r932645 - /incubator/aries/trunk/samples/ariestrader/pom.xml
Posted by Joe Bohn <jo...@gmail.com>.
Thanks for the reference. This makes sense. However, this makes the
other change you made right after this (r932648) all the more confusing.
Joe
On 4/13/10 12:50 PM, Jeremy Hughes wrote:
> On 12 April 2010 21:29, Joe Bohn<jo...@gmail.com> wrote:
>> Jeremy,
>>
>> Do you recall why these additions were necessary - what type of error you
>> hit without them?
>
>> From an email sent by David Jencks on Mar 2 [1]:
>
> 4. each subproject has dependency management for everything included
> in it. In addition, it has its subprojects listed in dependency
> management. (this is bent slightly for the samples). This means that
> (a) modules in a subproject don't need to include versions for use of
> other modules
> (b) you can get dependency management for all the modules in a
> subproject by depending on the subproject pom with scope import. (see
> the samples pom for an example).
>
> 5. As a result of (4), modules don't have any versions in any
> dependency elements.
>
> So I made this change to get the above behaviour. I don't recall the
> error as I had many of them throughout the whirlwind that was the
> release preparation. :-)
>
> [1] http://mail-archives.apache.org/mod_mbox/incubator-aries-dev/201003.mbox/%3C595020BE-A779-409C-A7F5-AE695731F2C0@yahoo.com%3E
>>
>> Joe
>>
>> On 4/9/10 7:14 PM, hughesj@apache.org wrote:
>>>
>>> Author: hughesj
>>> Date: Fri Apr 9 23:14:51 2010
>>> New Revision: 932645
>>>
>>> URL: http://svn.apache.org/viewvc?rev=932645&view=rev
>>> Log:
>>> ARIES-173 added dependency elements
>>>
>>> Modified:
>>> incubator/aries/trunk/samples/ariestrader/pom.xml
>>>
>>> Modified: incubator/aries/trunk/samples/ariestrader/pom.xml
>>> URL:
>>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/pom.xml?rev=932645&r1=932644&r2=932645&view=diff
>>>
>>> ==============================================================================
>>> --- incubator/aries/trunk/samples/ariestrader/pom.xml (original)
>>> +++ incubator/aries/trunk/samples/ariestrader/pom.xml Fri Apr 9 23:14:51
>>> 2010
>>> @@ -36,6 +36,20 @@
>>> <siteId>ariestrader</siteId>
>>> </properties>
>>>
>>> +<dependencyManagement>
>>> +<dependencies>
>>> +<dependency>
>>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>>> +<artifactId>modules</artifactId>
>>> +<version>${version}</version>
>>> +</dependency>
>>> +<dependency>
>>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>>> +<artifactId>assemblies</artifactId>
>>> +<version>${version}</version>
>>> +</dependency>
>>> +</dependencies>
>>> +</dependencyManagement>
>>>
>>> <modules>
>>> <!-- application components-->
>>>
>>>
>>>
>>
>>
>> --
>> Joe
>>
>
--
Joe
Re: svn commit: r932645 - /incubator/aries/trunk/samples/ariestrader/pom.xml
Posted by Jeremy Hughes <hu...@apache.org>.
On 12 April 2010 21:29, Joe Bohn <jo...@gmail.com> wrote:
> Jeremy,
>
> Do you recall why these additions were necessary - what type of error you
> hit without them?
>From an email sent by David Jencks on Mar 2 [1]:
4. each subproject has dependency management for everything included
in it. In addition, it has its subprojects listed in dependency
management. (this is bent slightly for the samples). This means that
(a) modules in a subproject don't need to include versions for use of
other modules
(b) you can get dependency management for all the modules in a
subproject by depending on the subproject pom with scope import. (see
the samples pom for an example).
5. As a result of (4), modules don't have any versions in any
dependency elements.
So I made this change to get the above behaviour. I don't recall the
error as I had many of them throughout the whirlwind that was the
release preparation. :-)
[1] http://mail-archives.apache.org/mod_mbox/incubator-aries-dev/201003.mbox/%3C595020BE-A779-409C-A7F5-AE695731F2C0@yahoo.com%3E
>
> Joe
>
> On 4/9/10 7:14 PM, hughesj@apache.org wrote:
>>
>> Author: hughesj
>> Date: Fri Apr 9 23:14:51 2010
>> New Revision: 932645
>>
>> URL: http://svn.apache.org/viewvc?rev=932645&view=rev
>> Log:
>> ARIES-173 added dependency elements
>>
>> Modified:
>> incubator/aries/trunk/samples/ariestrader/pom.xml
>>
>> Modified: incubator/aries/trunk/samples/ariestrader/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/incubator/aries/trunk/samples/ariestrader/pom.xml?rev=932645&r1=932644&r2=932645&view=diff
>>
>> ==============================================================================
>> --- incubator/aries/trunk/samples/ariestrader/pom.xml (original)
>> +++ incubator/aries/trunk/samples/ariestrader/pom.xml Fri Apr 9 23:14:51
>> 2010
>> @@ -36,6 +36,20 @@
>> <siteId>ariestrader</siteId>
>> </properties>
>>
>> +<dependencyManagement>
>> +<dependencies>
>> +<dependency>
>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>> +<artifactId>modules</artifactId>
>> +<version>${version}</version>
>> +</dependency>
>> +<dependency>
>> +<groupId>org.apache.aries.samples.ariestrader</groupId>
>> +<artifactId>assemblies</artifactId>
>> +<version>${version}</version>
>> +</dependency>
>> +</dependencies>
>> +</dependencyManagement>
>>
>> <modules>
>> <!-- application components-->
>>
>>
>>
>
>
> --
> Joe
>