You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Owen O'Malley (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 17:25:29 UTC
[jira] [Created] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Add nicer helper functions for adding and reading metadata from RCFiles
-----------------------------------------------------------------------
Key: HIVE-2898
URL: https://issues.apache.org/jira/browse/HIVE-2898
Project: Hive
Issue Type: New Feature
Components: Serializers/Deserializers
Reporter: Owen O'Malley
Assignee: Owen O'Malley
Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2898:
-----------------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks, Owen!
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.9.0
>
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch, HIVE-2898.D2433.5.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2898:
------------------------------
Attachment: HIVE-2898.D2433.4.patch
omalley updated the revision "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
Reviewers: JIRA
fixed one more mistake
REVISION DETAIL
https://reviews.facebook.net/D2433
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch, HIVE-2898.D2439.1.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2898) Add nicer helper functions for
adding and reading metadata from RCFiles
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239210#comment-13239210 ]
Phabricator commented on HIVE-2898:
-----------------------------------
ashutoshc has requested changes to the revision "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java:545 Should this be named createMetaData()?
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java:1215 This is not returning string to string map, rather just Text.
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java:1219 Should this be named getMetadataValueOf() ?
REVISION DETAIL
https://reviews.facebook.net/D2433
BRANCH
h-2898
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2898:
------------------------------
Attachment: HIVE-2898.D2439.1.patch
omalley requested code review of "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
Reviewers: JIRA
<<Enter Revision Title>>
fixed syntax error in test code
Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2439
AFFECTED FILES
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5475/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2439.1.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2898:
------------------------------
Attachment: HIVE-2898.D2433.3.patch
omalley updated the revision "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
Reviewers: JIRA
fixed a merge problem
REVISION DETAIL
https://reviews.facebook.net/D2433
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2439.1.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2898) Add nicer helper functions for
adding and reading metadata from RCFiles
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239917#comment-13239917 ]
Phabricator commented on HIVE-2898:
-----------------------------------
ashutoshc has accepted the revision "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
+1
REVISION DETAIL
https://reviews.facebook.net/D2433
BRANCH
h-2898
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch, HIVE-2898.D2433.5.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2898:
------------------------------
Attachment: HIVE-2898.D2433.2.patch
omalley updated the revision "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
Reviewers: JIRA
fixed syntax error in test
REVISION DETAIL
https://reviews.facebook.net/D2433
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2439.1.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2898:
------------------------------
Attachment: HIVE-2898.D2433.5.patch
omalley updated the revision "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
Reviewers: JIRA, ashutoshc
make ashutosh's suggested changes
REVISION DETAIL
https://reviews.facebook.net/D2433
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch, HIVE-2898.D2433.5.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2898) Add nicer helper functions for
adding and reading metadata from RCFiles
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13240907#comment-13240907 ]
Hudson commented on HIVE-2898:
------------------------------
Integrated in Hive-trunk-h0.21 #1338 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1338/])
HIVE-2898: Add nicer helper functions for adding and reading metadata from RCFiles (Owen Omalley via Ashutosh Chauhan) (Revision 1306464)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1306464
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
* /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 0.9.0
>
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch, HIVE-2898.D2433.5.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2898:
------------------------------
Attachment: HIVE-2898.D2433.1.patch
omalley requested code review of "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
Reviewers: JIRA
hive-2898
add helper functions for RCFile metadata
Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
TEST PLAN
add tests to test the new function calls
REVISION DETAIL
https://reviews.facebook.net/D2433
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java
ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5469/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2898) Add nicer helper functions for
adding and reading metadata from RCFiles
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236776#comment-13236776 ]
Phabricator commented on HIVE-2898:
-----------------------------------
omalley has abandoned the revision "HIVE-2898 [jira] Add nicer helper functions for adding and reading metadata from RCFiles".
This should have merged with the previous one.
REVISION DETAIL
https://reviews.facebook.net/D2439
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2439.1.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Owen O'Malley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HIVE-2898:
--------------------------------
Status: Patch Available (was: Open)
I ran the unit tests and they passed.
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2898) Add nicer helper functions for adding
and reading metadata from RCFiles
Posted by "Owen O'Malley (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HIVE-2898:
--------------------------------
Attachment: (was: HIVE-2898.D2439.1.patch)
> Add nicer helper functions for adding and reading metadata from RCFiles
> -----------------------------------------------------------------------
>
> Key: HIVE-2898
> URL: https://issues.apache.org/jira/browse/HIVE-2898
> Project: Hive
> Issue Type: New Feature
> Components: Serializers/Deserializers
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: HIVE-2898.D2433.1.patch, HIVE-2898.D2433.2.patch, HIVE-2898.D2433.3.patch, HIVE-2898.D2433.4.patch
>
>
> Currently, to use the metadata in RCFile, you need to manipulate it using SequenceFile.Metadata. I'd like to add two helper functions that make it more convenient.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira