You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/22 09:24:31 UTC

[GitHub] [cloudstack] DaanHoogland opened a new pull request, #6758: Ova download fix

DaanHoogland opened a new pull request, #6758:
URL: https://github.com/apache/cloudstack/pull/6758

   ### Description
   
   This PR allows for downloading OVA with the read properties from OVF flag when the OVF does not contain a minimum hardware version.
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   Fixes: #6736
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   by downloading an OVA that does not provide a minimum hardware version and making sure it is accepted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1254764055

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1259171181

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1258929265

   <b>Trillian test result (tid-5021)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43459 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6758-t5021-vmware-67u3.zip
   Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 764.42 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1260053370

   <b>Trillian test result (tid-5031)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 43658 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6758-t5031-vmware-67u3.zip
   Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 694.44 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1259174033

   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] borisstoyanov commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1260734021

   @blueorangutan test centos7 vmware-67u3 keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] nvazquez commented on a diff in pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
nvazquez commented on code in PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#discussion_r982563325


##########
engine/storage/src/main/java/org/apache/cloudstack/storage/image/deployasis/DeployAsIsHelperImpl.java:
##########
@@ -190,7 +194,7 @@ private Long retrieveTemplateGuestOsIdFromGuestOsInfo(long templateId, String gu
             }
             return guestOsId;
         } else {
-            throw new CloudRuntimeException("Did not find a guest OS with type " + guestOsType);
+            throw new CloudRuntimeException(String.format("Did not find a guest OS (%s) with type \"%s\" and minimal hyperviser hardware version %s.", guestOsDescription, guestOsType, minimumHardwareVersion));

Review Comment:
   Minor typo on 'hyperviser'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1254763909

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1254765018

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277889046

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1254772515

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6758 (SL-JID-2403)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1257778972

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277887605

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6758 (SL-JID-2495)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277330570

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] codecov[bot] commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1254893524

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6758?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6758](https://codecov.io/gh/apache/cloudstack/pull/6758?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3be72b9) into [main](https://codecov.io/gh/apache/cloudstack/commit/65c707042273a4067dc1749e10193fd3de165e0b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (65c7070) will **increase** coverage by `4.54%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #6758      +/-   ##
   ============================================
   + Coverage      5.88%   10.42%   +4.54%     
   - Complexity     3942     6705    +2763     
   ============================================
     Files          2454     2458       +4     
     Lines        242723   243250     +527     
     Branches      37988    38068      +80     
   ============================================
   + Hits          14289    25366   +11077     
   + Misses       226850   214709   -12141     
   - Partials       1584     3175    +1591     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6758?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...om/cloud/storage/dao/GuestOSHypervisorDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL2Rhby9HdWVzdE9TSHlwZXJ2aXNvckRhb0ltcGwuamF2YQ==) | `32.25% <0.00%> (-0.36%)` | :arrow_down: |
   | [...storage/image/deployasis/DeployAsIsHelperImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9pbWFnZS9kZXBsb3lhc2lzL0RlcGxveUFzSXNIZWxwZXJJbXBsLmphdmE=) | `13.26% <0.00%> (-0.21%)` | :arrow_down: |
   | [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `36.28% <0.00%> (-3.99%)` | :arrow_down: |
   | [...ain/java/com/cloud/consoleproxy/AgentHookBase.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbnNvbGVwcm94eS9BZ2VudEhvb2tCYXNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ava/com/cloud/servlet/ConsoleProxyClientParam.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3NlcnZsZXQvQ29uc29sZVByb3h5Q2xpZW50UGFyYW0uamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...va/com/cloud/consoleproxy/ConsoleProxyManager.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbnNvbGVwcm94eS9Db25zb2xlUHJveHlNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ud/consoleproxy/AgentBasedConsoleProxyManager.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2NvbnNvbGVwcm94eS9BZ2VudEJhc2VkQ29uc29sZVByb3h5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `62.60% <0.00%> (ø)` | |
   | [...tack/engine/orchestration/NetworkOrchestrator.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svZW5naW5lL29yY2hlc3RyYXRpb24vTmV0d29ya09yY2hlc3RyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../baremetal/networkservice/BaremetaNetworkGuru.java](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9iYXJlbWV0YWwvc3JjL21haW4vamF2YS9jb20vY2xvdWQvYmFyZW1ldGFsL25ldHdvcmtzZXJ2aWNlL0JhcmVtZXRhTmV0d29ya0d1cnUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [480 more](https://codecov.io/gh/apache/cloudstack/pull/6758/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277823901

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1258032070

   <b>Trillian test result (tid-5014)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 11465 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6758-t5014-vmware-67u3.zip
   Smoke tests completed. 13 look OK, 1 have errors, 89 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 981.10 | test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.01 | test_routers_network_ops.py
   ContextSuite context=TestIsolatedNetworks>:teardown | `Error` | 0.01 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.03 | test_routers_network_ops.py
   all_test_accounts | `Skipped` | --- | test_accounts.py
   all_test_persistent_network | `Skipped` | --- | test_persistent_network.py
   all_test_affinity_groups | `Skipped` | --- | test_affinity_groups.py
   all_test_migration | `Skipped` | --- | test_migration.py
   all_test_affinity_groups_projects | `Skipped` | --- | test_affinity_groups_projects.py
   all_test_router_dnsservice | `Skipped` | --- | test_router_dnsservice.py
   all_test_annotations | `Skipped` | --- | test_annotations.py
   all_test_routers | `Skipped` | --- | test_routers.py
   all_test_async_job | `Skipped` | --- | test_async_job.py
   all_test_multipleips_per_nic | `Skipped` | --- | test_multipleips_per_nic.py
   all_test_attach_multiple_volumes | `Skipped` | --- | test_attach_multiple_volumes.py
   all_test_nested_virtualization | `Skipped` | --- | test_nested_virtualization.py
   all_test_backup_recovery_dummy | `Skipped` | --- | test_backup_recovery_dummy.py
   all_test_portable_publicip | `Skipped` | --- | test_portable_publicip.py
   all_test_certauthority_root | `Skipped` | --- | test_certauthority_root.py
   all_test_portforwardingrules | `Skipped` | --- | test_portforwardingrules.py
   all_test_console_endpoint | `Skipped` | --- | test_console_endpoint.py
   all_test_internal_lb | `Skipped` | --- | test_internal_lb.py
   all_test_network | `Skipped` | --- | test_network.py
   all_test_deploy_vgpu_enabled_vm | `Skipped` | --- | test_deploy_vgpu_enabled_vm.py
   all_test_network_acl | `Skipped` | --- | test_network_acl.py
   all_test_deploy_virtio_scsi_vm | `Skipped` | --- | test_deploy_virtio_scsi_vm.py
   all_test_privategw_acl | `Skipped` | --- | test_privategw_acl.py
   all_test_deploy_vm_iso | `Skipped` | --- | test_deploy_vm_iso.py
   all_test_privategw_acl_ovs_gre | `Skipped` | --- | test_privategw_acl_ovs_gre.py
   all_test_deploy_vm_iso_uefi | `Skipped` | --- | test_deploy_vm_iso_uefi.py
   all_test_network_permissions | `Skipped` | --- | test_network_permissions.py
   all_test_deploy_vm_root_resize | `Skipped` | --- | test_deploy_vm_root_resize.py
   all_test_nic | `Skipped` | --- | test_nic.py
   all_test_usage | `Skipped` | --- | test_usage.py
   all_test_deploy_vm_with_userdata | `Skipped` | --- | test_deploy_vm_with_userdata.py
   all_test_diagnostics | `Skipped` | --- | test_diagnostics.py
   all_test_projects | `Skipped` | --- | test_projects.py
   all_test_direct_download | `Skipped` | --- | test_direct_download.py
   all_test_public_ip_range | `Skipped` | --- | test_public_ip_range.py
   all_test_disk_offerings | `Skipped` | --- | test_disk_offerings.py
   all_test_non_contigiousvlan | `Skipped` | --- | test_non_contigiousvlan.py
   all_test_disk_provisioning_types | `Skipped` | --- | test_disk_provisioning_types.py
   all_test_outofbandmanagement | `Skipped` | --- | test_outofbandmanagement.py
   all_test_domain_disk_offerings | `Skipped` | --- | test_domain_disk_offerings.py
   all_test_outofbandmanagement_nestedplugin | `Skipped` | --- | test_outofbandmanagement_nestedplugin.py
   all_test_domain_network_offerings | `Skipped` | --- | test_domain_network_offerings.py
   all_test_over_provisioning | `Skipped` | --- | test_over_provisioning.py
   all_test_domain_service_offerings | `Skipped` | --- | test_domain_service_offerings.py
   all_test_pvlan | `Skipped` | --- | test_pvlan.py
   all_test_domain_vpc_offerings | `Skipped` | --- | test_domain_vpc_offerings.py
   all_test_scale_vm | `Skipped` | --- | test_scale_vm.py
   all_test_dynamicroles | `Skipped` | --- | test_dynamicroles.py
   all_test_ipv6_infra | `Skipped` | --- | test_ipv6_infra.py
   all_test_vm_life_cycle | `Skipped` | --- | test_vm_life_cycle.py
   all_test_enable_account_settings_for_domain | `Skipped` | --- | test_enable_account_settings_for_domain.py
   all_test_iso | `Skipped` | --- | test_iso.py
   all_test_secondary_storage | `Skipped` | --- | test_secondary_storage.py
   all_test_enable_role_based_users_in_projects | `Skipped` | --- | test_enable_role_based_users_in_projects.py
   all_test_regions | `Skipped` | --- | test_regions.py
   all_test_events_resource | `Skipped` | --- | test_events_resource.py
   all_test_password_server | `Skipped` | --- | test_password_server.py
   all_test_gateway_on_shared_networks | `Skipped` | --- | test_gateway_on_shared_networks.py
   all_test_reset_configuration_settings | `Skipped` | --- | test_reset_configuration_settings.py
   all_test_global_settings | `Skipped` | --- | test_global_settings.py
   all_test_reset_vm_on_reboot | `Skipped` | --- | test_reset_vm_on_reboot.py
   all_test_guest_vlan_range | `Skipped` | --- | test_guest_vlan_range.py
   all_test_resource_accounting | `Skipped` | --- | test_resource_accounting.py
   all_test_service_offerings | `Skipped` | --- | test_service_offerings.py
   all_test_resource_detail | `Skipped` | --- | test_resource_detail.py
   all_test_hostha_simulator | `Skipped` | --- | test_hostha_simulator.py
   all_test_human_readable_logs | `Skipped` | --- | test_human_readable_logs.py
   all_test_kubernetes_clusters | `Skipped` | --- | test_kubernetes_clusters.py
   all_test_login | `Skipped` | --- | test_login.py
   all_test_snapshots | `Skipped` | --- | test_snapshots.py
   all_test_kubernetes_supported_versions | `Skipped` | --- | test_kubernetes_supported_versions.py
   all_test_router_dhcphosts | `Skipped` | --- | test_router_dhcphosts.py
   all_test_list_ids_parameter | `Skipped` | --- | test_list_ids_parameter.py
   all_test_ssvm | `Skipped` | --- | test_ssvm.py
   all_test_loadbalance | `Skipped` | --- | test_loadbalance.py
   all_test_metrics_api | `Skipped` | --- | test_metrics_api.py
   all_test_vm_snapshots | `Skipped` | --- | test_vm_snapshots.py
   all_test_routers_iptables_default_policy | `Skipped` | --- | test_routers_iptables_default_policy.py
   all_test_storage_policy | `Skipped` | --- | test_storage_policy.py
   all_test_update_security_group | `Skipped` | --- | test_update_security_group.py
   all_test_vm_lifecycle_unmanage_import | `Skipped` | --- | test_vm_lifecycle_unmanage_import.py
   all_test_vm_snapshot_kvm | `Skipped` | --- | test_vm_snapshot_kvm.py
   all_test_volumes | `Skipped` | --- | test_volumes.py
   all_test_vpc_ipv6 | `Skipped` | --- | test_vpc_ipv6.py
   all_test_vpc_redundant | `Skipped` | --- | test_vpc_redundant.py
   all_test_vpc_router_nics | `Skipped` | --- | test_vpc_router_nics.py
   all_test_vpc_vpn | `Skipped` | --- | test_vpc_vpn.py
   all_test_host_maintenance | `Skipped` | --- | test_host_maintenance.py
   all_test_hostha_kvm | `Skipped` | --- | test_hostha_kvm.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1262271442

   @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1254841921

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6758)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] borisstoyanov commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1262270233

   @blueorangutan test centos7 vmware-67u3 keepEnv


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277879976

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277333149

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1279082451

   > Upload from local fails when the user does not select 'read from OVA' ![Screenshot 2022-09-30 at 14 34 49](https://user-images.githubusercontent.com/13551960/193261219-353d56a2-b541-49e5-b03e-231f1e1041ab.png)
   
   @borisstoyanov I tested this with the macchinina template and it works, than I investigated the template for the cisco PI, it contains four disk definitions and only one vmdk. I am not sure if we should support this type of template, or how to handle it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1259106783

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1259106350

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1259174777

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277824717

   @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277948486

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6758)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland merged pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277880795

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277400553

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6758)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1254805038

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4245


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1254762950

   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1260444998

   @borisstoyanov @nvazquez can you please look at this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] borisstoyanov commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
borisstoyanov commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1260734452

   Sure @DaanHoogland, will do.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1263014296

   <b>Trillian test result (tid-5051)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 44143 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6758-t5051-vmware-67u3.zip
   Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_08_upgrade_kubernetes_ha_cluster | `Failure` | 627.03 | test_kubernetes_clusters.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1277349977

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6758 (SL-JID-2493)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1261110907

   @acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] blueorangutan commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1261122345

   UI build: :heavy_check_mark:
   Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6758 (SL-JID-2430)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] acs-robot commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1261110593

   Found UI changes, kicking a new UI QA build
   @blueorangutan ui


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#discussion_r982566537


##########
engine/storage/src/main/java/org/apache/cloudstack/storage/image/deployasis/DeployAsIsHelperImpl.java:
##########
@@ -190,7 +194,7 @@ private Long retrieveTemplateGuestOsIdFromGuestOsInfo(long templateId, String gu
             }
             return guestOsId;
         } else {
-            throw new CloudRuntimeException("Did not find a guest OS with type " + guestOsType);
+            throw new CloudRuntimeException(String.format("Did not find a guest OS (%s) with type \"%s\" and minimal hyperviser hardware version %s.", guestOsDescription, guestOsType, minimumHardwareVersion));

Review Comment:
   ```suggestion
               throw new CloudRuntimeException(String.format("Did not find a guest OS (%s) with type \"%s\" and minimal hypervisor hardware version %s.", guestOsDescription, guestOsType, minimumHardwareVersion));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] DaanHoogland commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1257777521

   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6758: Ova download fix

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#issuecomment-1261202564

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6758)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6758&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6758&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6758&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org