You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/07 04:46:28 UTC
[GitHub] [flink] xuefuz commented on a change in pull request #8339:
[FLINK-12240][hive] Support view related operations in
GenericHiveMetastoreCatalog
xuefuz commented on a change in pull request #8339: [FLINK-12240][hive] Support view related operations in GenericHiveMetastoreCatalog
URL: https://github.com/apache/flink/pull/8339#discussion_r281459369
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/GenericHiveMetastoreCatalogUtil.java
##########
@@ -118,18 +123,26 @@ public static Table createHiveTable(ObjectPath tablePath, CatalogBaseTable table
hiveTable.setPartitionKeys(new ArrayList<>());
}
- hiveTable.setSd(sd);
Review comment:
I'm wondering why we remove this line. If this is not needed, then we should probably remove everything about Sd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services