You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/14 15:45:32 UTC
[PR] Remove useless DialectDataTypeOption#isTextType [shardingsphere]
terrymanu opened a new pull request, #39115:
URL: https://github.com/apache/shardingsphere/pull/39115
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless DialectDataTypeOption#isTextType [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39115:
URL: https://github.com/apache/shardingsphere/pull/39115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove useless DialectDataTypeOption#isTextType [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39115:
URL: https://github.com/apache/shardingsphere/pull/39115#issuecomment-4971170748
### Summary
**Review Result: Mergeable**
Reason: The PR consistently removes an unused interface method and all in-repository implementations/tests. No code-level blocker was found. This is a code-scope result only; CI was not reviewed by request.
### Evidence
- No `isTextType` call sites remain at the PR head.
- All five `DialectDataTypeOption` implementations were updated consistently.
- Focused reactor tests passed with `BUILD SUCCESS` and zero failures/errors.
### Review Details
- Review Focus: Code Correctness Review
- Reviewed Scope: All 8 changed files in database connector core and MySQL, openGauss, Oracle, and PostgreSQL dialect modules. Head `7a4d65b9d3be896796ef8237e9d3545a6042f25d`; merge-base `b81630ab9cdebc94c8bb1f06ec72e0583aca3a29`. Local file list matched GitHub’s PR file list.
- Not Reviewed Scope: External downstream consumers of the public Java interface.
- Verification: Focused Maven reactor test command passed with exit code 0.
- CI not reviewed by request.
- Release Note / User Docs: Not required; this is an internal unused-method refactor with no user-facing behavior change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org