You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/10 06:38:27 UTC

[GitHub] [arrow] aocsa edited a comment on pull request #10802: ARROW-1568: [C++] Implement Drop Null Kernel for Arrays

aocsa edited a comment on pull request #10802:
URL: https://github.com/apache/arrow/pull/10802#issuecomment-895768466


   I updated the PR addressing feedback. 
   
   The following test cases were added.
   - 0-lengthed inputs (to test the early termination code paths)
   - non-zero but all null values on inputs (to test the early termination code paths)
   - Larger test case with more random values (say 1000 or so) --> Because bitmap ops work on 8 elements together. So, we need to test beyond 8 elements in an array.
   - Test with non-zero offsets in the inputs (for chunkedarrays and tables)
   
   cc @nirandaperera, @westonpace 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org