[GitHub] [accumulo] keith-turner commented on a change in pull request #2128: Change compaction priority from long to short (#2094)

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #2128:
URL: https://github.com/apache/accumulo/pull/2128#discussion_r643507560



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/ExternalCompactionExecutor.java
##########
@@ -190,10 +190,10 @@ ExternalCompactionJob reserveExternalCompaction(long priority, String compactorI
   }
 
   public Stream<TCompactionQueueSummary> summarize() {
-    HashSet<Long> uniqPrios = new HashSet<Long>();
+    HashSet<Short> uniqPrios = new HashSet<Short>();
     queuedTask.forEach(task -> uniqPrios.add(task.getJob().getPriority()));
 
-    Stream<Long> prioStream = uniqPrios.stream();
+    Stream<Short> prioStream = uniqPrios.stream();
 
     if (uniqPrios.size() > 100) {
       // Until #2094 is addressed limit what is sent to the coordinator to avoid causing it run out

Review comment:
       This comment could probably be removed.  Was not sure how #2094 would be addressed.  With short, thinking we may want to keep 100 limit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org