You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2005/02/07 23:48:25 UTC

Making svn:keywords fully case-insensitive

kfogel wished that there was a concise proposal not depending on previous 
context, so here it is :-)

Change:

Make the contents of svn:keyworks fully case-insensitive.


Objection raised by John Peacock (paraphrased):

Keywords are case-sensistive in the working file, they should be so in 
svn:keywords too. We can't case-sensitivize the ones that are insensitive 
now, for compatibility, but don't spread the problem, and let's make them 
all case-sensitive when we reach 2.0.


My response:

I agree full case-sensitivity would be nicer. But, I think making 
svn:keywords fully case-insensitive now is a step towards consistency, and 
doesn't in any way prohibit stricter canonicalization when we reach 2.0.



Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Making svn:keywords fully case-insensitive

Posted by kf...@collab.net.
Justin Erenkrantz <ju...@erenkrantz.com> writes:
> > But actually enforcing this when we reach 2.0 would annoy a lot of
> > people.  IMHO we should only enforce it if upgrading to 2.0 requires
> > some sort of dump/load or other one-time repository conversion step
> > anyway.  In that case, we could automatically fix the svn:keywords
> > property values as part of that conversion.
> 
> How would you fix the keywords?  Collapsing them (i.e. removing the
> 'duplicate') might lead to completely non-obvious results.  -- justin

Oh, I wasn't thinking of any collapsing.  Just any instances of (for
example) "rev" as a word in an svn:keywords value would become "Rev",
"author" -> "Author", etc.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Making svn:keywords fully case-insensitive

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Monday, February 7, 2005 6:20 PM -0600 kfogel@collab.net wrote:

> But actually enforcing this when we reach 2.0 would annoy a lot of
> people.  IMHO we should only enforce it if upgrading to 2.0 requires
> some sort of dump/load or other one-time repository conversion step
> anyway.  In that case, we could automatically fix the svn:keywords
> property values as part of that conversion.

How would you fix the keywords?  Collapsing them (i.e. removing the 
'duplicate') might lead to completely non-obvious results.  -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Making svn:keywords fully case-insensitive

Posted by Max Bowsher <ma...@ukf.net>.
kfogel@collab.net wrote:
> "Max Bowsher" <ma...@ukf.net> writes:
>> Change:
>>
>> Make the contents of svn:keyworks fully case-insensitive.
>>
>>
>> Objection raised by John Peacock (paraphrased):
>>
>> Keywords are case-sensistive in the working file, they should be so in
>> svn:keywords too. We can't case-sensitivize the ones that are
>> insensitive now, for compatibility, but don't spread the problem, and
>> let's make them all case-sensitive when we reach 2.0.
>>
>>
>> My response:
>>
>> I agree full case-sensitivity would be nicer. But, I think making
>> svn:keywords fully case-insensitive now is a step towards consistency,
>> and doesn't in any way prohibit stricter canonicalization when we
>> reach 2.0.
>
> Thanks, Max -- that was a tremendous help.
>
> So, I think I agree with John.  The best solution is simply to stop
> documenting the case-insensitive versions, and mention *only* the
> exact case-match versions.
>
> (Now that I look, I think we don't document the case-insensitive
> versions anywhere, by the way.)

OK, that's reasonable.

Should we document that the badly cased variants are deprecated?

> But actually enforcing this when we reach 2.0 would annoy a lot of
> people.  IMHO we should only enforce it if upgrading to 2.0 requires
> some sort of dump/load or other one-time repository conversion step
> anyway.  In that case, we could automatically fix the svn:keywords
> property values as part of that conversion.

It's pretty much guaranteed that this will be the case. We've already run 
into several "wouldn't it be nice if we could change the schema" issues:

- tracing history forwards
- displaying copy info on the copy _sources_


There will probably be more.

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Making svn:keywords fully case-insensitive

Posted by kf...@collab.net.
"Max Bowsher" <ma...@ukf.net> writes:
> Change:
> 
> Make the contents of svn:keyworks fully case-insensitive.
> 
> 
> Objection raised by John Peacock (paraphrased):
> 
> Keywords are case-sensistive in the working file, they should be so in
> svn:keywords too. We can't case-sensitivize the ones that are
> insensitive now, for compatibility, but don't spread the problem, and
> let's make them all case-sensitive when we reach 2.0.
> 
> 
> My response:
> 
> I agree full case-sensitivity would be nicer. But, I think making
> svn:keywords fully case-insensitive now is a step towards consistency,
> and doesn't in any way prohibit stricter canonicalization when we
> reach 2.0.

Thanks, Max -- that was a tremendous help.

So, I think I agree with John.  The best solution is simply to stop
documenting the case-insensitive versions, and mention *only* the
exact case-match versions.

But actually enforcing this when we reach 2.0 would annoy a lot of
people.  IMHO we should only enforce it if upgrading to 2.0 requires
some sort of dump/load or other one-time repository conversion step
anyway.  In that case, we could automatically fix the svn:keywords
property values as part of that conversion.

(Now that I look, I think we don't document the case-insensitive
versions anywhere, by the way.)

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org