You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@usergrid.apache.org by shawnfeldman <gi...@git.apache.org> on 2015/06/15 19:13:11 UTC
[GitHub] incubator-usergrid pull request: Usergrid 751 - change from smile ...
GitHub user shawnfeldman opened a pull request:
https://github.com/apache/incubator-usergrid/pull/282
Usergrid 751 - change from smile to json serializer, use string serialization
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-usergrid USERGRID-751
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-usergrid/pull/282.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #282
----
commit 7a264c4fe9e621e7c539b03a3399f32795e7341a
Author: Shawn Feldman <sf...@apache.org>
Date: 2015-06-15T15:56:08Z
adding index initialization step
commit 99615b3490b13c68da31cd1092030235ee1b0021
Author: Shawn Feldman <sf...@apache.org>
Date: 2015-06-15T17:11:48Z
change serializer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 751 - change from smile ...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/282#discussion_r32443921
--- Diff: stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/serialization/impl/MvccEntitySerializationStrategyV3Impl.java ---
@@ -458,9 +460,9 @@ public ByteBuffer toByteBuffer( final EntityWrapper wrapper ) {
final Entity entity = wrapper.entity.get();
//Convert to internal entity map
final EntityMap entityMap = EntityMap.fromEntity( entity );
- final byte[] entityBytes;
+ final String entityString;
try {
- entityBytes = MAPPER.writeValueAsBytes( entityMap );
+ entityString = MAPPER.writeValueAsString( entityMap );
--- End diff --
This still seems to use the fieldbuffer byte buffer. Can we remove this completely and just use a nested JSON object?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 751 - change from smile ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-usergrid/pull/282
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 751 - change from smile ...
Posted by tnine <gi...@git.apache.org>.
Github user tnine commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/282#discussion_r32443588
--- Diff: stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/serialization/impl/MvccEntitySerializationStrategyV3Impl.java ---
@@ -458,9 +460,9 @@ public ByteBuffer toByteBuffer( final EntityWrapper wrapper ) {
final Entity entity = wrapper.entity.get();
//Convert to internal entity map
final EntityMap entityMap = EntityMap.fromEntity( entity );
- final byte[] entityBytes;
--- End diff --
This still seems to use the fieldbuffer byte buffer. Can we remove this completely and just use a nested JSON object?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-usergrid pull request: Usergrid 751 - change from smile ...
Posted by shawnfeldman <gi...@git.apache.org>.
Github user shawnfeldman commented on a diff in the pull request:
https://github.com/apache/incubator-usergrid/pull/282#discussion_r32443845
--- Diff: stack/corepersistence/collection/src/main/java/org/apache/usergrid/persistence/collection/serialization/impl/MvccEntitySerializationStrategyV3Impl.java ---
@@ -458,9 +460,9 @@ public ByteBuffer toByteBuffer( final EntityWrapper wrapper ) {
final Entity entity = wrapper.entity.get();
//Convert to internal entity map
final EntityMap entityMap = EntityMap.fromEntity( entity );
- final byte[] entityBytes;
--- End diff --
i think it was removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---