You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Nitay Joffe <ni...@apache.org> on 2013/04/12 22:08:42 UTC
Re: Review Request: Merge remote-tracking branch 'origin/trunk' into
vertex-runner GIRAPH-614: SplitMasterWorker=false is broken (majakabiljo)
GIRAPH-616 GIRAPH-616: Decouple vertices and edges in
DiskBackedPartitionStore and avoid writing back edges when the algorithm
does not change topology.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10387/
-----------------------------------------------------------
(Updated April 12, 2013, 8:08 p.m.)
Review request for giraph.
Changes
-------
my bad, try this one.
Summary (updated)
-----------------
Merge remote-tracking branch 'origin/trunk' into vertex-runner GIRAPH-614: SplitMasterWorker=false is broken (majakabiljo) GIRAPH-616 GIRAPH-616: Decouple vertices and edges in DiskBackedPartitionStore and avoid writing back edges when the algorithm does not change topology.
Description
-------
InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses
This addresses bug GIRAPH-595.
https://issues.apache.org/jira/browse/GIRAPH-595
Diffs (updated)
-----
CHANGELOG 0012fa70f0074c735cc24d582592cd9fc8d7ff72
giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java 77fa83ccc785499dea8f6ddb829b54cbf3f4888a
giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java 58d3fee8162d46f3a114315fe833a89f4b65dbf8
giraph-core/src/main/java/org/apache/giraph/benchmark/WeightedPageRankBenchmark.java 4c76996de3346f78a1fc59e53661cbc2a8971c5b
giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java d67e0a5f2cad339eec03ca9669833ce3fdf06748
giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 0aeec4080c5b9c29b7d09d21e13abec6aaab20c0
giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java f6619c1428138104dd177eb0ed55f18f2ea3fa85
giraph-core/src/main/java/org/apache/giraph/io/formats/GiraphFileInputFormat.java fc4baa4c49ec88c7b87b2c320c14ec7359a2af12
giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java de7ea972e4cdaa2bc4097e04a725a6a2a3fb9171
giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java e389e013e563cb0748b2e2d0b8b7f6e059e666b9
giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java e5c2fddbc93a9996f67297c786518584ddc3f0e0
giraph-core/src/test/java/org/apache/giraph/BspCase.java f3c3358d028fa2118ac0c2d41fa29875076a3db1
giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java 0dcefd9191c4fc524dd986c24f8777c5bf00240d
giraph-core/src/test/java/org/apache/giraph/io/TestJsonBase64Format.java ae9441e03eeab26b5b92a18a8f3a0980c11c5055
giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java 8cd427ef195789a499bdabef894b359cfa400ad7
giraph-examples/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java 8a98e755811cabedbd5f16b88590f76ea4a0c56b
giraph-examples/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 386f67bdac272ed58770def912715ccb1b4d7297
giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java ab88b88636f3841dd51bf9a793a98726765cc8a5
giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java f7fa3f29c7821b7506bdd8b38e46c3992eafa90b
giraph-examples/src/test/java/org/apache/giraph/TestManualCheckpoint.java 210b78ae3a704f6974740dd29c23484965fc78b2
giraph-examples/src/test/java/org/apache/giraph/TestMaxSuperstep.java d7ac4e8846cc621269675e301532257318f4bcf5
giraph-examples/src/test/java/org/apache/giraph/TestMutateGraph.java 0427b85e6fd18e8565a7ce8b34c3e7300046e84a
giraph-examples/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 759624b1141b547f936cf0b4b0e554633fe01195
giraph-examples/src/test/java/org/apache/giraph/TestPartitionContext.java f236128823ee03f9793f0955f3d4e2c1effa2f60
giraph-examples/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java 372c32fb6bf9b94a37ed7a808525d483951c815a
giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java 55ca60ca95304d80ea0be084b42b93cb05822888
giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java e42f1727297fb40b4cf4c968f94868a40a67bf30
giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java 042dbe4c37f345515bb328a7dc544bd8a2d33a73
giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java f77ea3ee6e2f514e5401771cb5fee3536ba2159c
giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java e51b611efe99ba9e7decbc24bdcd605facd284ca
giraph-examples/src/test/java/org/apache/giraph/examples/TestPageRank.java 448afe674984ec0cadd7c38b64f9e9d14428ae4b
giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java 48153aeebcda5d56fabb8602b402c9355d71864f
Diff: https://reviews.apache.org/r/10387/diff/
Testing
-------
Thanks,
Nitay Joffe
Re: Review Request: Merge remote-tracking branch 'origin/trunk' into
vertex-runner GIRAPH-614: SplitMasterWorker=false is broken (majakabiljo)
GIRAPH-616 GIRAPH-616: Decouple vertices and edges in
DiskBackedPartitionStore and avoid writing back edges when the algorithm
does not change topology.
Posted by Alessandro Presta <al...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10387/#review19105
-----------------------------------------------------------
Looking good! I just need a clarification on the InternalZookeeper change which seems unrelated to the issue. +1
giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java
<https://reviews.apache.org/r/10387/#comment39652>
What issue does this fix?
- Alessandro Presta
On April 12, 2013, 8:08 p.m., Nitay Joffe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10387/
> -----------------------------------------------------------
>
> (Updated April 12, 2013, 8:08 p.m.)
>
>
> Review request for giraph.
>
>
> Description
> -------
>
> InternalVertexRunner.run() should take GiraphConfiguration, not GiraphClasses
>
>
> This addresses bug GIRAPH-595.
> https://issues.apache.org/jira/browse/GIRAPH-595
>
>
> Diffs
> -----
>
> CHANGELOG 0012fa70f0074c735cc24d582592cd9fc8d7ff72
> giraph-core/src/main/java/org/apache/giraph/benchmark/PageRankBenchmark.java 77fa83ccc785499dea8f6ddb829b54cbf3f4888a
> giraph-core/src/main/java/org/apache/giraph/benchmark/ShortestPathsBenchmark.java 58d3fee8162d46f3a114315fe833a89f4b65dbf8
> giraph-core/src/main/java/org/apache/giraph/benchmark/WeightedPageRankBenchmark.java 4c76996de3346f78a1fc59e53661cbc2a8971c5b
> giraph-core/src/main/java/org/apache/giraph/conf/ClassConfOption.java d67e0a5f2cad339eec03ca9669833ce3fdf06748
> giraph-core/src/main/java/org/apache/giraph/conf/GiraphConfiguration.java 0aeec4080c5b9c29b7d09d21e13abec6aaab20c0
> giraph-core/src/main/java/org/apache/giraph/conf/ImmutableClassesGiraphConfiguration.java f6619c1428138104dd177eb0ed55f18f2ea3fa85
> giraph-core/src/main/java/org/apache/giraph/io/formats/GiraphFileInputFormat.java fc4baa4c49ec88c7b87b2c320c14ec7359a2af12
> giraph-core/src/main/java/org/apache/giraph/utils/ConfigurationUtils.java de7ea972e4cdaa2bc4097e04a725a6a2a3fb9171
> giraph-core/src/main/java/org/apache/giraph/utils/InternalVertexRunner.java e389e013e563cb0748b2e2d0b8b7f6e059e666b9
> giraph-core/src/main/java/org/apache/giraph/utils/TestGraph.java e5c2fddbc93a9996f67297c786518584ddc3f0e0
> giraph-core/src/test/java/org/apache/giraph/BspCase.java f3c3358d028fa2118ac0c2d41fa29875076a3db1
> giraph-core/src/test/java/org/apache/giraph/io/TestEdgeInput.java 0dcefd9191c4fc524dd986c24f8777c5bf00240d
> giraph-core/src/test/java/org/apache/giraph/io/TestJsonBase64Format.java ae9441e03eeab26b5b92a18a8f3a0980c11c5055
> giraph-core/src/test/java/org/apache/giraph/master/TestMasterObserver.java 8cd427ef195789a499bdabef894b359cfa400ad7
> giraph-examples/src/main/java/org/apache/giraph/examples/SimpleShortestPathsVertex.java 8a98e755811cabedbd5f16b88590f76ea4a0c56b
> giraph-examples/src/test/java/org/apache/giraph/TestAutoCheckpoint.java 386f67bdac272ed58770def912715ccb1b4d7297
> giraph-examples/src/test/java/org/apache/giraph/TestBspBasic.java ab88b88636f3841dd51bf9a793a98726765cc8a5
> giraph-examples/src/test/java/org/apache/giraph/TestGraphPartitioner.java f7fa3f29c7821b7506bdd8b38e46c3992eafa90b
> giraph-examples/src/test/java/org/apache/giraph/TestManualCheckpoint.java 210b78ae3a704f6974740dd29c23484965fc78b2
> giraph-examples/src/test/java/org/apache/giraph/TestMaxSuperstep.java d7ac4e8846cc621269675e301532257318f4bcf5
> giraph-examples/src/test/java/org/apache/giraph/TestMutateGraph.java 0427b85e6fd18e8565a7ce8b34c3e7300046e84a
> giraph-examples/src/test/java/org/apache/giraph/TestNotEnoughMapTasks.java 759624b1141b547f936cf0b4b0e554633fe01195
> giraph-examples/src/test/java/org/apache/giraph/TestPartitionContext.java f236128823ee03f9793f0955f3d4e2c1effa2f60
> giraph-examples/src/test/java/org/apache/giraph/aggregators/TestAggregatorsHandling.java 372c32fb6bf9b94a37ed7a808525d483951c815a
> giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTest.java 55ca60ca95304d80ea0be084b42b93cb05822888
> giraph-examples/src/test/java/org/apache/giraph/examples/ConnectedComponentsVertexTestInMemory.java e42f1727297fb40b4cf4c968f94868a40a67bf30
> giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java 042dbe4c37f345515bb328a7dc544bd8a2d33a73
> giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java f77ea3ee6e2f514e5401771cb5fee3536ba2159c
> giraph-examples/src/test/java/org/apache/giraph/examples/SimpleShortestPathsVertexTest.java e51b611efe99ba9e7decbc24bdcd605facd284ca
> giraph-examples/src/test/java/org/apache/giraph/examples/TestPageRank.java 448afe674984ec0cadd7c38b64f9e9d14428ae4b
> giraph-examples/src/test/java/org/apache/giraph/examples/TryMultiIpcBindingPortsTest.java 48153aeebcda5d56fabb8602b402c9355d71864f
>
> Diff: https://reviews.apache.org/r/10387/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Nitay Joffe
>
>