[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4310: Prevents line breaks in delivery service remapText field (UI and API)

[GitBox <gi...@apache.org>]

mitchell852 opened a new pull request #4310: Prevents line breaks in delivery service remapText field (UI and API)
URL: https://github.com/apache/trafficcontrol/pull/4310
 
 
   ## What does this PR (Pull Request) do?
   
   Rejects delivery service remapText with line breaks as it will result in a malformed remap.config file.
   
   - [x] This PR fixes #4298 
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Ops
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   1. Run the [UI tests](https://github.com/apache/trafficcontrol/tree/master/traffic_portal/test/end_to_end)
   2. Run the API tests
   3. Manually verify in TP by trying to enter a line break in the `Raw Remap Text` delivery service form field for a DNS, HTTP or ANY_MAP delivery service.
   4. Attempt to create or update a delivery service using the API where remapText contains \n or \r. It should fail.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master (6b11bd9)
   - 3.1.0
   - 4.0.0 (RC1)
   
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [trafficcontrol] mitchell852 closed pull request #4310: Prevents line breaks in delivery service remapText field (UI and API)

[GitBox <gi...@apache.org>]

mitchell852 closed pull request #4310: Prevents line breaks in delivery service remapText field (UI and API)
URL: https://github.com/apache/trafficcontrol/pull/4310
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services