You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/11/29 02:57:39 UTC
[GitHub] [skywalking] hanahmily opened a new issue #8195: [Feature] Java agent injection for kubernetes
hanahmily opened a new issue #8195:
URL: https://github.com/apache/skywalking/issues/8195
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Introduce a new case that shows how the java agent injector works to showcase repo.
We can add a new `feature` into the repo by referring to the [agentless case](https://github.com/apache/skywalking-showcase/blob/9b9e6a7f661df67e9d0396afe972da2cff1bfe61/deploy/platform/kubernetes/features.mk?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L57) which is recommended by @kezhenxu94
In this feature, we should
* create two new namespaces, one is for the operator, the other is to deploy the demo app.
* deploy the swck operator and the demo app.
* update the agent's backend address to the `single-node` or `cluster` feature. (Their address is identical. One of them should be deployed with this feature)
@dashanji Do you interest in this?
@wu-sheng @kezhenxu94 any insight about this?
### Use case
_No response_
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #8195: [Feature][Showcase] Java agent injection for kubernetes
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #8195:
URL: https://github.com/apache/skywalking/issues/8195#issuecomment-981283247
> I don't have to make showcase complex, as we never have a chance to cover all user cases. Showcase should be simple, straight forward, no option. Otherwise, it makes no different with current documentation. I prefer to write a document(I think we have it already, right?) and a step-by-step blog(more searchable in the search engine) to introduce this feature.
Make sense. a canonical path is better and neater than many options. I will update the task list accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dashanji commented on issue #8195: [Feature][Showcase] Java agent injection for kubernetes
Posted by GitBox <gi...@apache.org>.
dashanji commented on issue #8195:
URL: https://github.com/apache/skywalking/issues/8195#issuecomment-981288515
Yes, I'd like to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #8195: [Feature][Showcase] Java agent injection for kubernetes
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #8195:
URL: https://github.com/apache/skywalking/issues/8195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8195: [Feature][Showcase] Java agent injection for kubernetes
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8195:
URL: https://github.com/apache/skywalking/issues/8195#issuecomment-981261533
I would recommend you to read this discussion context. https://github.com/apache/skywalking-kubernetes/pull/83#issuecomment-979649648
I don't have to make showcase complex, as we never have a chance to cover all user cases. Showcase should be simple, straight forward, no option. Otherwise, it makes no different with current documentation.
I prefer to write a document(I think we have it already, right?) and a step-by-step blog(more searchable in the search engine) to introduce this feature.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] hanahmily commented on issue #8195: [Feature][Showcase] Java agent injection for kubernetes
Posted by GitBox <gi...@apache.org>.
hanahmily commented on issue #8195:
URL: https://github.com/apache/skywalking/issues/8195#issuecomment-981255641
> Are we going to remove the `agent-image` based solution? Using injection to replace?
FWIK, `agent-image` solution is broadly used in kubernetes environment. I prefer adding a new feature instead of replacing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #8195: [Feature][Showcase] Java agent injection for kubernetes
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #8195:
URL: https://github.com/apache/skywalking/issues/8195#issuecomment-981251850
Are we going to remove the `agent-image` based solution? Using injection to replace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org