You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/01/13 10:34:47 UTC
Review Request 42245: Streamline the usage pattern for kinit'ing in
code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42245/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-14646
https://issues.apache.org/jira/browse/AMBARI-14646
Repository: ambari
Description
-------
Library methods such as `ExecuteHadoop` has the ability to call kinit if
appropriate parameters are specified but it looks like its not being used.
This results in bugs as folks
may forget to add the statement to kinit at the right place.
We should look into all location where `ExecuteHadoop` is used and check if
the usage can be cleaned up. There are about 6 services that use
`ExecuteHadoop` so it should not be a large task and we should use the
inherent ability to kinit that is available.
If for some reason it can't be used then lets remove the code to kinit from
the implementation of `ExecuteHadoop`.
Diffs
-----
ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 264398b
ambari-common/src/main/python/resource_management/libraries/providers/execute_hadoop.py 7b9fdab
ambari-common/src/main/python/resource_management/libraries/resources/execute_hadoop.py 73dd1a3
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 12ca1ad
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py dcca88e
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 36d9133
ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py b755d46
Diff: https://reviews.apache.org/r/42245/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 42245: Streamline the usage pattern for kinit'ing
in code
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42245/#review114166
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Jan. 13, 2016, 11:34 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42245/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2016, 11:34 a.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-14646
> https://issues.apache.org/jira/browse/AMBARI-14646
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Library methods such as `ExecuteHadoop` has the ability to call kinit if
> appropriate parameters are specified but it looks like its not being used.
> This results in bugs as folks
> may forget to add the statement to kinit at the right place.
>
> We should look into all location where `ExecuteHadoop` is used and check if
> the usage can be cleaned up. There are about 6 services that use
> `ExecuteHadoop` so it should not be a large task and we should use the
> inherent ability to kinit that is available.
>
> If for some reason it can't be used then lets remove the code to kinit from
> the implementation of `ExecuteHadoop`.
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/resource_management/TestExecuteHadoopResource.py 264398b
> ambari-common/src/main/python/resource_management/libraries/providers/execute_hadoop.py 7b9fdab
> ambari-common/src/main/python/resource_management/libraries/resources/execute_hadoop.py 73dd1a3
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py 12ca1ad
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py dcca88e
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_namenode.py 36d9133
> ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_service_check.py b755d46
>
> Diff: https://reviews.apache.org/r/42245/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>