[GitHub] [tvm] electriclilies commented on a change in pull request #9729: [CORE] Make external mods first class field in the IR module

[GitBox <gi...@apache.org>]

electriclilies commented on a change in pull request #9729:
URL: https://github.com/apache/tvm/pull/9729#discussion_r768016573



##########
File path: include/tvm/ir/module.h
##########
@@ -57,6 +57,8 @@ class IRModuleNode : public Object {
   Map<GlobalVar, BaseFunc> functions;
   /*! \brief A map from global type vars to ADT type data. */
   Map<GlobalTypeVar, TypeData> type_definitions;
+  /*! \brief The external module containing the external functions used by this module. */
+  Array<runtime::Module> external_mods;

Review comment:
       @comaniac It would be great if we could have a discussion about this instead of you just saying it's not the correct approach. 
   
   Currently, the external modules are stored in the IRModule attributes, so they are already mixed, it's just not made explicit in the AST. This change just moves the external modules out of the attributes and into the IRModule as a field. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org