You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Andrzej Bialecki (JIRA)" <ji...@apache.org> on 2010/05/13 14:50:41 UTC
[jira] Created: (LUCENE-2459) FilterIndexReader doesn't work
correctly with post-flex SegmentMerger
FilterIndexReader doesn't work correctly with post-flex SegmentMerger
---------------------------------------------------------------------
Key: LUCENE-2459
URL: https://issues.apache.org/jira/browse/LUCENE-2459
Project: Lucene - Java
Issue Type: Bug
Affects Versions: 4.0
Reporter: Andrzej Bialecki
Attachments: FIRTest.patch
IndexWriter.addIndexes(IndexReader...) internally uses SegmentMerger to add data from input index readers. However, SegmentMerger uses the new post-flex API to do this, which bypasses the pre-flex TermEnum/TermPositions API that FilterIndexReader implements. As a result, filtering is not applied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2459) FilterIndexReader doesn't work
correctly with post-flex SegmentMerger
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless resolved LUCENE-2459.
----------------------------------------
Fix Version/s: 4.0
Resolution: Fixed
Thanks Andrzej!
> FilterIndexReader doesn't work correctly with post-flex SegmentMerger
> ---------------------------------------------------------------------
>
> Key: LUCENE-2459
> URL: https://issues.apache.org/jira/browse/LUCENE-2459
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Andrzej Bialecki
> Fix For: 4.0
>
> Attachments: FIRTest.patch, LUCENE-2459.patch
>
>
> IndexWriter.addIndexes(IndexReader...) internally uses SegmentMerger to add data from input index readers. However, SegmentMerger uses the new post-flex API to do this, which bypasses the pre-flex TermEnum/TermPositions API that FilterIndexReader implements. As a result, filtering is not applied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2459) FilterIndexReader doesn't work
correctly with post-flex SegmentMerger
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki updated LUCENE-2459:
--------------------------------------
Attachment: FIRTest.patch
Modified unit test to illustrate the problem.
> FilterIndexReader doesn't work correctly with post-flex SegmentMerger
> ---------------------------------------------------------------------
>
> Key: LUCENE-2459
> URL: https://issues.apache.org/jira/browse/LUCENE-2459
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Andrzej Bialecki
> Attachments: FIRTest.patch
>
>
> IndexWriter.addIndexes(IndexReader...) internally uses SegmentMerger to add data from input index readers. However, SegmentMerger uses the new post-flex API to do this, which bypasses the pre-flex TermEnum/TermPositions API that FilterIndexReader implements. As a result, filtering is not applied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2459) FilterIndexReader doesn't work
correctly with post-flex SegmentMerger
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867165#action_12867165 ]
Michael McCandless commented on LUCENE-2459:
--------------------------------------------
Thanks Andrzej -- this is indeed a bug.
Your fix (using flex API on pre-flex API emulation) is good for now, so I think we can commit to trunk. But, we are going to remove the pre-flex APIs (and make the flex APIs abstract) soonish, at which point all FilterIndexReader impls for trunk will have to cutover to flex.
I'll commit shortly.
> FilterIndexReader doesn't work correctly with post-flex SegmentMerger
> ---------------------------------------------------------------------
>
> Key: LUCENE-2459
> URL: https://issues.apache.org/jira/browse/LUCENE-2459
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Andrzej Bialecki
> Attachments: FIRTest.patch, LUCENE-2459.patch
>
>
> IndexWriter.addIndexes(IndexReader...) internally uses SegmentMerger to add data from input index readers. However, SegmentMerger uses the new post-flex API to do this, which bypasses the pre-flex TermEnum/TermPositions API that FilterIndexReader implements. As a result, filtering is not applied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2459) FilterIndexReader doesn't work
correctly with post-flex SegmentMerger
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrzej Bialecki updated LUCENE-2459:
--------------------------------------
Attachment: LUCENE-2459.patch
The test passes with this patch. I'm not completely sure it coveres all cases, though.
> FilterIndexReader doesn't work correctly with post-flex SegmentMerger
> ---------------------------------------------------------------------
>
> Key: LUCENE-2459
> URL: https://issues.apache.org/jira/browse/LUCENE-2459
> Project: Lucene - Java
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Andrzej Bialecki
> Attachments: FIRTest.patch, LUCENE-2459.patch
>
>
> IndexWriter.addIndexes(IndexReader...) internally uses SegmentMerger to add data from input index readers. However, SegmentMerger uses the new post-flex API to do this, which bypasses the pre-flex TermEnum/TermPositions API that FilterIndexReader implements. As a result, filtering is not applied.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org