You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Matej Knopp (JIRA)" <ji...@apache.org> on 2007/09/02 00:47:19 UTC

[jira] Resolved: (WICKET-909) onBeforeRender not called on ModalWindow contents

     [ https://issues.apache.org/jira/browse/WICKET-909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matej Knopp resolved WICKET-909.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.0-beta4

> onBeforeRender not called on ModalWindow contents
> -------------------------------------------------
>
>                 Key: WICKET-909
>                 URL: https://issues.apache.org/jira/browse/WICKET-909
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.3.0-beta3
>         Environment: Tomcat 5.5.1
> Windows
> Eclipse + wtp
>            Reporter: Thomas Mäder
>            Assignee: Matej Knopp
>            Priority: Minor
>             Fix For: 1.3.0-beta4
>
>         Attachments: TestModal.zip
>
>
> ModalWindow.onBeforeRender contains the following code:
> 		super.onBeforeRender();
> 		getContent().setOutputMarkupId(true);
> 		getContent().setVisible(shown);
> This has the consequence that the content of the modal windows is still invisible when its onBeforeRender() method is called. The default implementation of onBeforeRender delegates to the window's children beforeRender() method. However, the contents beforeRender() method first checks if the component is visible, which is not the case, so the onBeforeRender()  call is not propagated down the component tree. 
> This is a problem if the content of the modal window is something like a table, which populates itself in the onBeforeRender call. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.